Merge lp:~cmiller/ubuntu/quantal/deluge/fix-parameter-move-storage into lp:ubuntu/quantal/deluge

Proposed by Chad Miller
Status: Merged
Merged at revision: 37
Proposed branch: lp:~cmiller/ubuntu/quantal/deluge/fix-parameter-move-storage
Merge into: lp:ubuntu/quantal/deluge
Diff against target: 113 lines (+38/-8)
3 files modified
debian/changelog (+9/-0)
debian/control (+8/-8)
debian/patches/move-fails.patch (+21/-0)
To merge this branch: bzr merge lp:~cmiller/ubuntu/quantal/deluge/fix-parameter-move-storage
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+121302@code.launchpad.net
To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-05-22 15:16:48 +0000
3+++ debian/changelog 2012-08-25 01:14:18 +0000
4@@ -1,3 +1,12 @@
5+deluge (1.3.5-1ubuntu2) quantal; urgency=low
6+
7+ * Add patch to fix function parameter on call to libtorrent to move storage.
8+ It doesn't want Unicode.
9+ * Set minimum version dependency higher to catch new function signature.
10+ * Fix grammar in control.
11+
12+ -- Andrew Starr-Bochicchio <a.starr.b@gmail.com> Fri, 24 Aug 2012 21:04:04 -0400
13+
14 deluge (1.3.5-1ubuntu1) quantal; urgency=low
15
16 * Merge from Debian Experimental (LP: #990629). Remaining Ubuntu changes:
17
18=== modified file 'debian/control'
19--- debian/control 2012-05-22 15:16:48 +0000
20+++ debian/control 2012-08-25 01:14:18 +0000
21@@ -28,7 +28,7 @@
22 Replaces: deluge-torrent-common (<< 1.0.7.dfsg-1), deluge-torrent (<< 1.0.7.dfsg-1), deluge-core (<< 1.2.0~rc1-1)
23 Description: bittorrent client written in Python/PyGTK (common files)
24 Deluge is a full-featured, multi-platform, multi-interface BitTorrent client
25- using libtorrent-rasterbar in it's backend and featuring multiple
26+ using libtorrent-rasterbar in its back end and featuring multiple
27 user-interfaces: GTK+, web and console.
28 .
29 It has been designed using the client-server model with a daemon process that
30@@ -43,12 +43,12 @@
31 Architecture: all
32 Depends: ${misc:Depends}, ${python:Depends},
33 deluge-common (= ${source:Version}),
34- python-libtorrent (>= 0.14.9),
35+ python-libtorrent (>= 0.16.0),
36 adduser,
37 lsb-base (>= 3.2-14)
38 Description: bittorrent client written in Python/PyGTK (daemon)
39 Deluge is a full-featured, multi-platform, multi-interface BitTorrent client
40- using libtorrent-rasterbar in it's backend and featuring multiple
41+ using libtorrent-rasterbar in its back end and featuring multiple
42 user-interfaces: GTK+, web and console.
43 .
44 It has been designed using the client-server model with a daemon process that
45@@ -66,7 +66,7 @@
46 deluge-common (= ${source:Version})
47 Description: bittorrent client written in Python/PyGTK (console ui)
48 Deluge is a full-featured, multi-platform, multi-interface BitTorrent client
49- using libtorrent-rasterbar in it's backend and featuring multiple
50+ using libtorrent-rasterbar in its back end and featuring multiple
51 user-interfaces: GTK+, web and console.
52 .
53 It has been designed using the client-server model with a daemon process that
54@@ -85,7 +85,7 @@
55 Replaces: deluge-webui (<< 1.2.0~rc1-1)
56 Description: bittorrent client written in Python/PyGTK (web ui)
57 Deluge is a full-featured, multi-platform, multi-interface BitTorrent client
58- using libtorrent-rasterbar in it's backend and featuring multiple
59+ using libtorrent-rasterbar in its back end and featuring multiple
60 user-interfaces: GTK+, web and console.
61 .
62 It has been designed using the client-server model with a daemon process that
63@@ -112,7 +112,7 @@
64 python-appindicator
65 Description: bittorrent client written in Python/PyGTK (GTK+ ui)
66 Deluge is a full-featured, multi-platform, multi-interface BitTorrent client
67- using libtorrent-rasterbar in it's backend and featuring multiple
68+ using libtorrent-rasterbar in its back end and featuring multiple
69 user-interfaces: GTK+, web and console.
70 .
71 It has been designed using the client-server model with a daemon process that
72@@ -127,13 +127,13 @@
73 Package: deluge
74 Architecture: all
75 Depends: ${misc:Depends}, ${python:Depends},
76- python-libtorrent (>= 0.14.9),
77+ python-libtorrent (>= 0.16.0),
78 deluge-gtk (= ${source:Version})
79 Breaks: deluge-common (<< 1.2.0~rc1-1)
80 Replaces: deluge-common (<< 1.2.0~rc1-1)
81 Description: bittorrent client written in Python/PyGTK
82 Deluge is a full-featured, multi-platform, multi-interface BitTorrent client
83- using libtorrent-rasterbar in it's backend and featuring multiple
84+ using libtorrent-rasterbar in its back end and featuring multiple
85 user-interfaces: GTK+, web and console.
86 .
87 It has been designed using the client-server model with a daemon process that
88
89=== added file 'debian/patches/move-fails.patch'
90--- debian/patches/move-fails.patch 1970-01-01 00:00:00 +0000
91+++ debian/patches/move-fails.patch 2012-08-25 01:14:18 +0000
92@@ -0,0 +1,21 @@
93+Description: The torrent library changed its function signature.
94+Forwarded: no
95+Origin: other
96+Author: Chad Miller <chad@canonical.com>
97+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/deluge/+bug/1041415
98+
99+--- deluge/core/torrent.py 2012-04-10 11:27:37 +0000
100++++ deluge/core/torrent.py 2012-08-25 00:57:04 +0000
101+@@ -851,8 +851,10 @@
102+ log.error("Could not move storage for torrent %s since %s does not exist and could not create the directory.", self.torrent_id, dest_u)
103+ return False
104+ try:
105+- self.handle.move_storage(dest_u)
106++ self.handle.move_storage(dest.encode("utf-8"))
107++ # Unicode doesn't match libtorrent. This smells buggy elsewhere.
108+ except:
109++ log.exception("Can not move storage to %s", dest)
110+ return False
111+
112+ return True
113+

Subscribers

People subscribed via source and target branches

to all changes: