Merge lp:~cmiller/desktopcouch/use-library-to-replicate into lp:desktopcouch

Proposed by Chad Miller
Status: Merged
Approved by: Chad Miller
Approved revision: 254
Merged at revision: 256
Proposed branch: lp:~cmiller/desktopcouch/use-library-to-replicate
Merge into: lp:desktopcouch
Diff against target: 28 lines (+3/-5)
1 file modified
desktopcouch/application/pair/couchdb_pairing/couchdb_io.py (+3/-5)
To merge this branch: bzr merge lp:~cmiller/desktopcouch/use-library-to-replicate
Reviewer Review Type Date Requested Status
Martin Albisetti (community) Approve
Eric Casteleijn (community) Approve
Review via email: mp+45566@code.launchpad.net

Commit message

Change to the new system of initiating replication with python-couchdb. (LP: #700128)

To post a comment you must log in.
Revision history for this message
Eric Casteleijn (thisfred) wrote :

I like it!

review: Approve
Revision history for this message
Martin Albisetti (beuno) :
review: Approve
Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :
Download full text (30.5 KiB)

The attempt to merge lp:~cmiller/desktopcouch/use-library-to-replicate into lp:desktopcouch failed. Below is the output from the failed tests.

Apache CouchDB has started, time to relax.
Browse your desktop CouchDB at file:///tmp/tmpdSvDjc/data/couchdb.html
desktopcouch.application.tests.test_start_local_couchdb
  TestUpdateDesignDocuments
    test_create_databases_and_design_docs ... [OK]
desktopcouch.application.tests.test_service
  TestService
    test_start_desktopcouch_replication ... [OK]
    test_start_new_desktopcouch_extensions ... [OK]
    test_start_new_desktopcouch_no_extensions ... [OK]
desktopcouch.application.tests.test_local_files
  TestKeyringIntegration
    test_with_auth ... [OK]
    test_with_no_auth ... [OK]
  TestLocalFiles
    test_all_files_returned ... [OK]
    test_bind_address ... [OK]
    test_couch_chain_ini_files ... [OK]
    test_xdg_overwrite_works ... [OK]
desktopcouch.application.tests.test_replication
  TestReplication
    test_creation ... Apache CouchDB has started, time to relax.
Browse your desktop CouchDB at file:///tmp/tmpv5BArG/data/couchdb.html
                                                     [OK]
  TestUbuntuoneReplication
    test_exclusion ... Apache CouchDB has started, time to relax.
Browse your desktop CouchDB at file:///tmp/tmpcAHGjK/data/couchdb.html
                                                    [OK]
desktopcouch.application.migration.tests.test_migration
  TestMigration
    test_migration_deleted_flag_to_trash ... [OK]
    test_migration_in_face_of_broken_records ... [OK]
    test_migration_script_is_run ... [OK]
    test_migration_script_is_run_and_can_access_view ... [OK]
  TestRegistration
    test_register_migration_is_added_to_the_registry ... [OK]
desktopcouch.application.platform.linux.tests.test_keyring
  TestGnomeKeyring
    test_get_aouth_no_keyring ... [OK]
    test_get_oauth_canceled_store ... [OK]
    test_get_oauth_data_stored ... [OK]
    test_get_user_name_password_keyring ... [OK]
    test_get_user_name_password_no_daemon ... [OK]
    test_get_user_name_password_not_in_keyring ... [OK]
    test_get_user_name_password_user_cancel ... [OK]
desktopcouch.application.platform.windows.tests.test_keyring
  TestKeyring
    test_get_oauth_data ... [OK]
    test_get_user_name_password ... [OK]
    test_get_user_name_password_no_key ... ...

Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :
Download full text (30.6 KiB)

The attempt to merge lp:~cmiller/desktopcouch/use-library-to-replicate into lp:desktopcouch failed. Below is the output from the failed tests.

Apache CouchDB has started, time to relax.
Browse your desktop CouchDB at file:///tmp/tmpl92E6m/data/couchdb.html
desktopcouch.application.tests.test_start_local_couchdb
  TestUpdateDesignDocuments
    test_create_databases_and_design_docs ... [OK]
desktopcouch.application.tests.test_service
  TestService
    test_start_desktopcouch_replication ... [OK]
    test_start_new_desktopcouch_extensions ... [OK]
    test_start_new_desktopcouch_no_extensions ... [OK]
desktopcouch.application.tests.test_local_files
  TestKeyringIntegration
    test_with_auth ... [OK]
    test_with_no_auth ... [OK]
  TestLocalFiles
    test_all_files_returned ... [OK]
    test_bind_address ... [OK]
    test_couch_chain_ini_files ... [OK]
    test_xdg_overwrite_works ... [OK]
desktopcouch.application.tests.test_replication
  TestReplication
    test_creation ... Apache CouchDB has started, time to relax.
Browse your desktop CouchDB at file:///tmp/tmpksxkHq/data/couchdb.html
                                                     [OK]
  TestUbuntuoneReplication
    test_exclusion ... Apache CouchDB has started, time to relax.
Browse your desktop CouchDB at file:///tmp/tmpvvk8Ib/data/couchdb.html
                                                    [OK]
desktopcouch.application.migration.tests.test_migration
  TestMigration
    test_migration_deleted_flag_to_trash ... [OK]
    test_migration_in_face_of_broken_records ... [OK]
    test_migration_script_is_run ... [OK]
    test_migration_script_is_run_and_can_access_view ... [OK]
  TestRegistration
    test_register_migration_is_added_to_the_registry ... [OK]
desktopcouch.application.platform.linux.tests.test_keyring
  TestGnomeKeyring
    test_get_aouth_no_keyring ... [OK]
    test_get_oauth_canceled_store ... [OK]
    test_get_oauth_data_stored ... [OK]
    test_get_user_name_password_keyring ... [OK]
    test_get_user_name_password_no_daemon ... [OK]
    test_get_user_name_password_not_in_keyring ... [OK]
    test_get_user_name_password_user_cancel ... [OK]
desktopcouch.application.platform.windows.tests.test_keyring
  TestKeyring
    test_get_oauth_data ... [OK]
    test_get_user_name_password ... [OK]
    test_get_user_name_password_no_key ... ...

254. By Chad Miller

Shorten line to placate pylint.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'desktopcouch/application/pair/couchdb_pairing/couchdb_io.py'
2--- desktopcouch/application/pair/couchdb_pairing/couchdb_io.py 2010-11-26 22:58:19 +0000
3+++ desktopcouch/application/pair/couchdb_pairing/couchdb_io.py 2011-01-10 17:05:05 +0000
4@@ -294,7 +294,6 @@
5 assert "consumer_secret" in target_oauth
6 target = dict(url=target, auth=dict(oauth=target_oauth))
7
8- record = dict(source=source, target=target)
9 try:
10 # regardless of source and target, we talk to our local couchdb :(
11 if not local_uri:
12@@ -307,13 +306,12 @@
13
14 # All until python-couchdb gets a Server.replicate() function
15 local_server = server.DesktopServer(local_uri, ctx=ctx)
16- resp, data = local_server.resource.post(path='/_replicate',
17- content=record)
18+ resp, data = local_server.replicate(source, target)
19 logging.debug(
20 "replicate result: %r %r", obsfuscate(resp), obsfuscate(data))
21 except: # pylint: disable=W0702
22- logging.exception("can't replicate %r %r <== %r", source_database,
23- local_uri, obsfuscate(record))
24+ logging.exception("can't replicate %r %r <= %r to %r", source_database,
25+ local_uri, obsfuscate(source), obsfuscate(target))
26
27
28 def get_pairings(uri=None, ctx=local_files.DEFAULT_CONTEXT):

Subscribers

People subscribed via source and target branches