Merge lp:~cmiller/desktopcouch/u1-repl-prefix-http-error-causes-future-nameerrors into lp:desktopcouch

Proposed by Chad Miller
Status: Merged
Approved by: dobey
Approved revision: 182
Merged at revision: 184
Proposed branch: lp:~cmiller/desktopcouch/u1-repl-prefix-http-error-causes-future-nameerrors
Merge into: lp:desktopcouch
Diff against target: 18 lines (+2/-2)
1 file modified
desktopcouch/replication_services/ubuntuone.py (+2/-2)
To merge this branch: bzr merge lp:~cmiller/desktopcouch/u1-repl-prefix-http-error-causes-future-nameerrors
Reviewer Review Type Date Requested Status
dobey (community) Approve
Vincenzo Di Somma (community) Approve
Review via email: mp+37730@code.launchpad.net

Commit message

Fix a problem with ubuntuone replication that will cause NameErrors if the first attempt at replication throws an exception. In recent changes, this code was left indented at the wrong level. (LP: #655267)

To post a comment you must log in.
Revision history for this message
Vincenzo Di Somma (vds) :
review: Approve
Revision history for this message
dobey (dobey) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'desktopcouch/replication_services/ubuntuone.py'
2--- desktopcouch/replication_services/ubuntuone.py 2010-09-27 21:57:29 +0000
3+++ desktopcouch/replication_services/ubuntuone.py 2010-10-06 12:29:43 +0000
4@@ -80,12 +80,12 @@
5 oauth_data['consumer_secret'])
6 access_token = oauth.OAuthToken(oauth_data['token'],
7 oauth_data['token_secret'])
8+ self.oauth_header = get_oauth_request_header(
9+ consumer, access_token, url)
10 except:
11 logging.exception("Could not get access token from sso.")
12 raise ValueError("No access token.")
13
14- self.oauth_header = get_oauth_request_header(
15- consumer, access_token, url)
16
17 client = httplib2.Http()
18 resp, content = client.request(url, "GET", headers=self.oauth_header)

Subscribers

People subscribed via source and target branches