Merge lp:~clissold345/ubuntu-docs/fix-for-1624778 into lp:~ubuntu-core-doc/ubuntu-docs/trunk2017-07-10

Proposed by Chris Perry
Status: Merged
Approved by: Gunnar Hjalmarsson
Approved revision: 552
Merged at revision: 553
Proposed branch: lp:~clissold345/ubuntu-docs/fix-for-1624778
Merge into: lp:~ubuntu-core-doc/ubuntu-docs/trunk2017-07-10
Diff against target: 38 lines (+6/-15)
1 file modified
ubuntu-help/C/tips-specialchars.page (+6/-15)
To merge this branch: bzr merge lp:~clissold345/ubuntu-docs/fix-for-1624778
Reviewer Review Type Date Requested Status
Gunnar Hjalmarsson Approve
Review via email: mp+306690@code.launchpad.net

Description of the change

I've updated the file tips-specialchars.page to fix launchpad bug 1624778. The procedure is now correct for 16.04 (and presumably 16.10). Someone has already updated the equivalent GNOME help so in part I've copied that. Even for such a short piece of text I had some choices to make. Eg I don't see the point of listing the keys that can be set as the compose key so I've deleted that sentence. "Open <application-name>" is used elsewhere in the desktop help so that's what I've used in step 2. I use "select" as much as possible and only use "click" where "select" doesn't seem to make sense. Etc, Etc. I haven't checked or altered the other sections on the page. I deleted an obsolete comment.

To post a comment you must log in.
Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

Thanks, Chris! The branch and the merge proposal seem to be perfect in a technical sense. I haven't checked the actual content changes yet, but will do soon.

I'm not going to merge anything before we have added the updated translations for 16.10 to lp:ubuntu-docs, which will happen next Thursday or Friday.

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

I think the "Compose key" section looks good after your changes.

On 2016-09-24 20:37, clissold345 wrote:
> I don't see the point of listing the keys that can be set as the
> compose key so I've deleted that sentence.

Agreed.

> I deleted an obsolete comment.

Actually you replaced the obsolete comment with a new one. ;)

Comment sections are only present on pages where they are needed, and the revision history of the pages is available in the Bazaar branch. Consequently I would suggest that the whole comment section is removed instead.

To accomplish that change, I suggest that you remove the comment section, commit it as a separate revision in your local branch copy, and then push again.

review: Needs Fixing
552. By Chris Perry

Removed <comment> section - no longer needed

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

Thanks for the update; looks good now.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntu-help/C/tips-specialchars.page'
2--- ubuntu-help/C/tips-specialchars.page 2016-06-25 17:35:38 +0000
3+++ ubuntu-help/C/tips-specialchars.page 2016-09-27 15:28:41 +0000
4@@ -27,13 +27,6 @@
5
6 <title>Enter special characters</title>
7
8- <comment>
9- <cite date="2012-02-19">shaunm</cite>
10- <p>Marking complete for 3.0. We didn't get keyboard-inputmethods in.
11- If we get it for 3.0.1, uncomment the last section, write something,
12- and link.</p>
13- </comment>
14-
15 <p>You can enter and view thousands of characters from most of the
16 world's writing systems, even those not found on your keyboard. This
17 page lists some different ways you can enter special characters.</p>
18@@ -65,14 +58,12 @@
19 <title>Define a compose key</title>
20 <item><p>Click the icon at the very right of the <gui>menu bar</gui>
21 and select <gui>System Settings</gui>.</p></item>
22- <item><p>Click <gui>Keyboard Layout</gui>.</p></item>
23- <item><p>Click
24- <gui>Options</gui>.</p></item>
25- <item><p>Find the group called <gui>Compose key position</gui>.
26- Select the key or keys you would like to behave as a compose key.
27- You can choose keys like <key>Caps Lock</key>, either of the
28- <key>Alt</key> keys, or the menu key. Any keys you select will
29- then only work as a compose key, and will no longer work for their
30+ <item><p>Open <gui>Keyboard</gui>.</p></item>
31+ <item><p>Select the <gui>Shortcuts</gui> tab.</p></item>
32+ <item><p>Select the <gui>Typing</gui> category in the left pane.</p></item>
33+ <item><p>Select <gui>Compose Key</gui> in the right pane.</p></item>
34+ <item><p>Click on <gui>Disabled</gui> and select a key from the drop-down menu.
35+ Note: The key you select will only work as a compose key, and will no longer work for its
36 original purpose.</p></item>
37 </steps>
38 <p>You can type many common characters using the compose key, for

Subscribers

People subscribed via source and target branches