Merge ~clinton-fung/launchpadlib:remove-indentation-parenthesis-in-url-output into launchpadlib:main

[Clinton Fung]

Remove indentation and parentheses when outputting URL for auth on the command-line, to make copy/paste easier and more predictable across platforms.

Currently, when executing `Launchpad.login_with()`, if authentication is required then a URL is printed to allow the user to open a browser and perform authentication.

This message looks something like:
```
The authorization page:
 (https://launchpad.net/+authorize-token?oauth_token=blah&allow_permission=DESKTOP_INTEGRATION)
should be opening in your browser. Use your browser to authorize
this program to access Launchpad on your behalf.
Waiting to hear from Launchpad about your decision...
```

It would be helpful if the indentation and parentheses around the URL were removed, to make copy/paste easier (and presumably to make the URL easier to read for machines in automation).

This change simply removes the indentation and parentheses.

[Colin Watson (cjwatson)]

I'd like to keep the indentation if possible (perhaps increased to two or four spaces), since it marks it out from the surrounding prose a bit more clearly. Both Firefox and Chromium trim leading spaces from URLs, presumably to make this sort of pattern work more easily, so I don't think that should be as much of a problem as the parentheses. Do you agree?

review: Needs Information

Unmerged commits

bf031cf... by Clinton Fung on 2023-02-20

Remove indentation and parentheses when outputting URL for auth on the command-line, to make copy/paste easier and more predictable across platforms.

	lint:0 (build)
	tests:0 (build)

1 → 2 of 2 results

First • Previous • Next • Last

diff --git a/src/launchpadlib/credentials.py b/src/launchpadlib/credentials.py
index 5789fc0..63fc32a 100644
--- a/src/launchpadlib/credentials.py
+++ b/src/launchpadlib/credentials.py
@@ -731,7 +731,7 @@ class AuthorizeRequestTokenWithBrowser(AuthorizeRequestTokenWithURL):
 
     WAITING_FOR_USER = (
         "The authorization page:\n"
-        " (%s)\n"
+        "%s\n"
         "should be opening in your browser. Use your browser to authorize\n"
         "this program to access Launchpad on your behalf."
     )