~clinton-fung/launchpad:account-deletion-person-merge-skip01

Branch merges

Propose for merging

Merged into launchpad:master

Colin Watson (community): Approve on 2023-02-07

Diff: 50 lines (+21/-0)

2 files modified

lib/lp/registry/scripts/closeaccount.py (+2/-0)
lib/lp/registry/scripts/tests/test_closeaccount.py (+19/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

3e93666... by Clinton Fung on 2023-02-08

Re-order tests, remove in-lined code from _do_premerge() by using placeholder logic instead.

	docs:0 (build)
	lint:0 (build)
	mypy:0 (build)

1 → 3 of 3 results

First • Previous • Next • Last

c582bd9... by Clinton Fung on 2023-02-07

Add a skip for person.merged (and also personnotification.person) to allow account closure to proceed

	docs:0 (build)
	lint:0 (build)
	mypy:0 (build)

1 → 3 of 3 results

First • Previous • Next • Last

3eeae61... by Colin Watson on 2023-02-04

Move ZCML securedutility directive to lp namespace

Merged from https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/436846

	docs:0 (build)
	lint:0 (build)
	mypy:0 (build)

1 → 3 of 3 results

First • Previous • Next • Last

ef0f99a... by Colin Watson on 2023-02-03

Move ZCML securedutility directive to lp namespace

As with commit 57196c1d6a220f00039e027768cc05368135f556, it makes sense
to move our local `securedutility` directive to our own namespace rather
than poking it into the Zope namespace, even though it's a bit like the
Zope `utility` directive. This is a big patch, but it's mostly
mechanical.

615a609... by Colin Watson on 2023-02-03

Move ZCML authorizations directive to lp namespace

Merged from https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/436831

57196c1... by Colin Watson on 2023-02-03

Move ZCML authorizations directive to lp namespace

While experimenting with https://github.com/collective/zpretty, I
noticed that Launchpad installs a number of ZCML directives under the
XML namespaces http://namespaces.zope.org/browser,
http://namespaces.zope.org/mail, and http://namespaces.zope.org/zope.
As well as feeling a bit rude, this also makes it difficult to integrate
properly with auto-formatting tools such as `zpretty` that can benefit
from being told about details of the preferred ordering of attributes
for each tag.

We have a perfectly good http://namespaces.canonical.com/lp XML
namespace that we already use for a few ZCML directives, so I think it
would make sense to move our other local directives to that. There'll
be a bit of readjustment, but it should also have the benefit that it
will be more obvious at a glance where to start looking for the
definition of a given directive (this is something I've had difficulty
with in the past).

As an initial proof of concept, this commit moves the `authorizations`
directive to http://namespaces.canonical.com/lp.

808055a... by Colin Watson on 2023-02-03

Remove two old build dispatch arguments

Merged from https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/436622

50b0509... by Colin Watson on 2023-02-03

Avoid six.ensure_* in obvious cases

Merged from https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/436828

e77de9d... by Colin Watson on 2023-02-03

Avoid six.ensure_* in obvious cases

If we're dealing with something where it's obvious whether it's `bytes`
or `str` (e.g. a literal or something that we just did an `isinstance`
check on), then there's no need to use `six.ensure_*`; just use
`.decode`/`.encode` directly.

`lp.testing.pages.http` accepts either `bytes` or `str`.

41b7913... by Colin Watson on 2023-02-02

Fix source package recipe webservice query count tests

Merged from https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/436768