Ubuntu
libdbi package

Merge lp:~clint-fewbar/ubuntu/natty/libdbi/no-fast-math into lp:ubuntu/natty/libdbi

  1. Natty (11.04)
  2. no-fast-math
  3. Merge into natty
Proposed by Clint Byrum
Status: Merged
Merged at revision: 5
Proposed branch: lp:~clint-fewbar/ubuntu/natty/libdbi/no-fast-math
Merge into: lp:ubuntu/natty/libdbi
Diff against target: 40 lines (+9/-2)
3 files modified
configure (+1/-1)
configure.in (+1/-1)
debian/changelog (+7/-0)
To merge this branch: bzr merge lp:~clint-fewbar/ubuntu/natty/libdbi/no-fast-math
Reviewer Review Type Date Requested Status
Martin Pitt Approve
Colin Watson Needs Fixing
Review via email: mp+45447@code.launchpad.net

Description of the change

Appends -fno-fast-math in configure script.

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) :
review: Approve
Revision history for this message
Colin Watson (cjwatson) wrote :

It's not a good idea to change only a generated file and not its source. The next time somebody runs autoconf your fix will be dropped.

Could you please change configure.in too?

review: Needs Fixing
Revision history for this message
Clint Byrum (clint-fewbar) wrote :

On Fri, 2011-01-07 at 13:31 +0000, Colin Watson wrote:
> Review: Needs Fixing
> It's not a good idea to change only a generated file and not its source. The next time somebody runs autoconf your fix will be dropped.
>
> Could you please change configure.in too?

Makes perfect sense.

Pushed w/ configure.in changed as well.

lp:~clint-fewbar/ubuntu/natty/libdbi/no-fast-math updated
6. By Clint Byrum

configure.in, configure: patched CFLAGS to pass -fno-fast-math to
prevent floating point problems on i386 (LP: #673307)

Revision history for this message
Martin Pitt (pitti) wrote :

Thanks, this looks good now!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'configure'
2--- configure 2010-07-28 12:44:39 +0000
3+++ configure 2011-01-07 17:49:14 +0000
4@@ -19257,7 +19257,7 @@
5 case $host in
6 *-*-linux*)
7 DEBUG="-g -Wall -D_REENTRANT -D__NO_MATH_INLINES -fsigned-char -std=gnu99"
8- CFLAGS="-O20 -ffast-math -D_REENTRANT -fsigned-char -std=gnu99"
9+ CFLAGS="-O20 -ffast-math -D_REENTRANT -fsigned-char -std=gnu99 -fno-fast-math"
10 PROFILE="-pg -g -O20 -ffast-math -D_REENTRANT -fsigned-char -std=gnu99";;
11 sparc-sun-*)
12 DEBUG="-g -Wall -D__NO_MATH_INLINES -fsigned-char -mv8 -std=gnu99"
13
14=== modified file 'configure.in'
15--- configure.in 2010-07-28 12:44:39 +0000
16+++ configure.in 2011-01-07 17:49:14 +0000
17@@ -55,7 +55,7 @@
18 case $host in
19 *-*-linux*)
20 DEBUG="-g -Wall -D_REENTRANT -D__NO_MATH_INLINES -fsigned-char -std=gnu99"
21- CFLAGS="-O20 -ffast-math -D_REENTRANT -fsigned-char -std=gnu99"
22+ CFLAGS="-O20 -ffast-math -D_REENTRANT -fsigned-char -std=gnu99 -fno-fast-math"
23 PROFILE="-pg -g -O20 -ffast-math -D_REENTRANT -fsigned-char -std=gnu99";;
24 sparc-sun-*)
25 DEBUG="-g -Wall -D__NO_MATH_INLINES -fsigned-char -mv8 -std=gnu99"
26
27=== modified file 'debian/changelog'
28--- debian/changelog 2010-07-28 12:44:39 +0000
29+++ debian/changelog 2011-01-07 17:49:14 +0000
30@@ -1,3 +1,10 @@
31+libdbi (0.8.3-0ubuntu2) natty; urgency=low
32+
33+ * configure.in, configure: patched CFLAGS to pass -fno-fast-math to
34+ prevent floating point problems on i386 (LP: #673307)
35+
36+ -- Clint Byrum <clint@ubuntu.com> Fri, 07 Jan 2011 09:46:04 -0800
37+
38 libdbi (0.8.3-0ubuntu1) maverick; urgency=low
39
40 * New upstream release.

Subscribers

People subscribed via source and target branches

to all changes: