Merge lp:~clint-fewbar/ubuntu/maverick/php5/fix-lp564920 into lp:ubuntu/maverick/php5

Proposed by Clint Byrum
Status: Merged
Merge reported by: Thierry Carrez
Merged at revision: not available
Proposed branch: lp:~clint-fewbar/ubuntu/maverick/php5/fix-lp564920
Merge into: lp:ubuntu/maverick/php5
Diff against target: 50 lines (+30/-0)
3 files modified
debian/changelog (+6/-0)
debian/patches/lp564920-fix-big-files.patch (+23/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~clint-fewbar/ubuntu/maverick/php5/fix-lp564920
Reviewer Review Type Date Requested Status
Thierry Carrez (community) Approve
Ubuntu branches Pending
Review via email: mp+32001@code.launchpad.net

Description of the change

Applying Marc's patch to fix this issue.

To post a comment you must log in.
Revision history for this message
Thierry Carrez (ttx) wrote :

Looks good. I tend to word-wrap long lines in debian/changelog though :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2010-08-05 20:00:34 +0000
3+++ debian/changelog 2010-08-06 21:24:48 +0000
4@@ -1,3 +1,9 @@
5+php5 (5.3.3-1ubuntu3) maverick; urgency=low
6+
7+ * debian/patches/lp564920-fix-big-files.patch: Fix downloading of large files (LP: #564920)
8+
9+ -- Clint Byrum <clint@ubuntu.com> Fri, 06 Aug 2010 13:10:17 -0700
10+
11 php5 (5.3.3-1ubuntu2) maverick; urgency=low
12
13 * debian/control: Use netcat rather than netcat-traditional.
14
15=== added file 'debian/patches/lp564920-fix-big-files.patch'
16--- debian/patches/lp564920-fix-big-files.patch 1970-01-01 00:00:00 +0000
17+++ debian/patches/lp564920-fix-big-files.patch 2010-08-06 21:24:48 +0000
18@@ -0,0 +1,23 @@
19+Description: don't mmap large files
20+Author: Marc Deslauriers <marc.deslauriers@ubuntu.com>
21+Bug: http://bugs.php.net/bug.php?id=52102
22+Ubuntu-Bug: https://bugs.edge.launchpad.net/ubuntu/+source/php5/+bug/564920
23+
24+diff -Nur php5-5.3.2/main/streams/plain_wrapper.c php5-5.3.2.new/main/streams/plain_wrapper.c
25+--- php5-5.3.2/main/streams/plain_wrapper.c 2010-02-23 10:04:29.000000000 -0500
26++++ php5-5.3.2.new/main/streams/plain_wrapper.c 2010-07-14 18:24:13.000000000 -0400
27+@@ -627,7 +627,13 @@
28+
29+ switch (value) {
30+ case PHP_STREAM_MMAP_SUPPORTED:
31+- return fd == -1 ? PHP_STREAM_OPTION_RETURN_ERR : PHP_STREAM_OPTION_RETURN_OK;
32++ if (fd == -1)
33++ return PHP_STREAM_OPTION_RETURN_ERR;
34++ /* Don't mmap large files */
35++ do_fstat(data, 1);
36++ if (data->sb.st_size > 4 * 1024 * 1024)
37++ return PHP_STREAM_OPTION_RETURN_ERR;
38++ return PHP_STREAM_OPTION_RETURN_OK;
39+
40+ case PHP_STREAM_MMAP_MAP_RANGE:
41+ do_fstat(data, 1);
42
43=== modified file 'debian/patches/series'
44--- debian/patches/series 2010-08-01 11:58:54 +0000
45+++ debian/patches/series 2010-08-06 21:24:48 +0000
46@@ -55,3 +55,4 @@
47 fpm_gcc_atomics.patch
48 php-fpm-man-section-and-cleanup.patch
49 fpm-config.patch
50+lp564920-fix-big-files.patch

Subscribers

People subscribed via source and target branches

to all changes: