Merge lp:~clint-fewbar/txaws/drop-pytz into lp:txaws

Proposed by Clint Byrum
Status: Merged
Merge reported by: Thomas Herve
Merged at revision: not available
Proposed branch: lp:~clint-fewbar/txaws/drop-pytz
Merge into: lp:txaws
Prerequisite: lp:~clint-fewbar/txaws/drop-epsilon
Diff against target: 102 lines (+10/-10)
4 files modified
txaws/server/resource.py (+2/-2)
txaws/server/schema.py (+2/-2)
txaws/server/tests/test_resource.py (+3/-3)
txaws/server/tests/test_schema.py (+3/-3)
To merge this branch: bzr merge lp:~clint-fewbar/txaws/drop-pytz
Reviewer Review Type Date Requested Status
Thomas Herve Approve
Review via email: mp+87703@code.launchpad.net

Description of the change

drops pytz for equivalent dateutil calls

To post a comment you must log in.
Revision history for this message
Thomas Herve (therve) wrote :

Thanks, +1!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'txaws/server/resource.py'
2--- txaws/server/resource.py 2011-12-20 10:40:24 +0000
3+++ txaws/server/resource.py 2012-01-06 01:06:29 +0000
4@@ -1,6 +1,6 @@
5 from datetime import datetime, timedelta
6 from uuid import uuid4
7-from pytz import UTC
8+from dateutil.tz import tzutc
9
10 from twisted.python import log
11 from twisted.python.reflect import safe_str
12@@ -159,7 +159,7 @@
13
14 def get_utc_time(self):
15 """Return a C{datetime} object with the current time in UTC."""
16- return datetime.now(UTC)
17+ return datetime.now(tzutc())
18
19 def _validate(self, request):
20 """Validate an L{HTTPRequest} before executing it.
21
22=== modified file 'txaws/server/schema.py'
23--- txaws/server/schema.py 2011-12-01 14:19:12 +0000
24+++ txaws/server/schema.py 2012-01-06 01:06:29 +0000
25@@ -1,7 +1,7 @@
26 from datetime import datetime
27 from operator import itemgetter
28
29-from pytz import UTC
30+from dateutil.tz import tzutc
31
32 from zope.datetime import parse, SyntaxError
33
34@@ -243,7 +243,7 @@
35
36 def parse(self, value):
37 try:
38- return datetime(*parse(value, local=False)[:6], tzinfo=UTC)
39+ return datetime(*parse(value, local=False)[:6], tzinfo=tzutc())
40 except (TypeError, SyntaxError):
41 raise ValueError()
42
43
44=== modified file 'txaws/server/tests/test_resource.py'
45--- txaws/server/tests/test_resource.py 2011-12-20 10:40:24 +0000
46+++ txaws/server/tests/test_resource.py 2012-01-06 01:06:29 +0000
47@@ -1,7 +1,7 @@
48 from json import dumps, loads
49-from pytz import UTC
50 from cStringIO import StringIO
51 from datetime import datetime
52+from dateutil.tz import tzutc
53
54 from twisted.trial.unittest import TestCase
55 from twisted.python.reflect import safe_str
56@@ -542,7 +542,7 @@
57 self.assertEqual("data", request.response)
58 self.assertEqual(200, request.code)
59
60- now = datetime(2009, 12, 31, tzinfo=UTC)
61+ now = datetime(2009, 12, 31, tzinfo=tzutc())
62 self.api.get_utc_time = lambda: now
63 self.api.principal = TestPrincipal(creds)
64 return self.api.handle(request).addCallback(check)
65@@ -567,7 +567,7 @@
66 " 2010-01-01T12:00:00Z", request.response)
67 self.assertEqual(400, request.code)
68
69- now = datetime(2010, 1, 1, 12, 0, 1, tzinfo=UTC)
70+ now = datetime(2010, 1, 1, 12, 0, 1, tzinfo=tzutc())
71 self.api.get_utc_time = lambda: now
72 return self.api.handle(request).addCallback(check)
73
74
75=== modified file 'txaws/server/tests/test_schema.py'
76--- txaws/server/tests/test_schema.py 2011-12-01 14:30:28 +0000
77+++ txaws/server/tests/test_schema.py 2012-01-06 01:06:29 +0000
78@@ -2,7 +2,7 @@
79
80 from datetime import datetime
81
82-from pytz import UTC, FixedOffset
83+from dateutil.tz import tzutc, tzoffset
84
85 from twisted.trial.unittest import TestCase
86
87@@ -318,7 +318,7 @@
88 def test_parse(self):
89 """L{Date.parse checks that the given raw C{value} is a date/time."""
90 parameter = Date("Test")
91- date = datetime(2010, 9, 15, 23, 59, 59, tzinfo=UTC)
92+ date = datetime(2010, 9, 15, 23, 59, 59, tzinfo=tzutc())
93 self.assertEqual(date, parameter.parse("2010-09-15T23:59:59Z"))
94
95 def test_format(self):
96@@ -328,7 +328,7 @@
97 """
98 parameter = Date("Test")
99 date = datetime(2010, 9, 15, 23, 59, 59,
100- tzinfo=FixedOffset(120))
101+ tzinfo=tzoffset('UTC', 120*60))
102 self.assertEqual("2010-09-15T21:59:59Z", parameter.format(date))
103
104

Subscribers

People subscribed via source and target branches

to all changes: