Merge lp:~clint-fewbar/txaws/drop-epsilon into lp:txaws

Proposed by Clint Byrum on 2012-01-06
Status: Merged
Merge reported by: Thomas Herve
Merged at revision: not available
Proposed branch: lp:~clint-fewbar/txaws/drop-epsilon
Merge into: lp:txaws
Diff against target: 50 lines (+5/-6)
2 files modified
setup.py (+2/-2)
txaws/s3/client.py (+3/-4)
To merge this branch: bzr merge lp:~clint-fewbar/txaws/drop-epsilon
Reviewer Review Type Date Requested Status
Thomas Herve 2012-01-06 Approve on 2012-01-06
Review via email: mp+87700@code.launchpad.net

Description of the Change

Change epsilon library to dateutil

To post a comment you must log in.
Thomas Herve (therve) wrote :

Thanks +1!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'setup.py'
2--- setup.py 2011-03-30 19:39:55 +0000
3+++ setup.py 2012-01-06 00:05:26 +0000
4@@ -5,12 +5,12 @@
5 from txaws import version
6
7 # If setuptools is present, use it to find_packages(), and also
8-# declare our dependency on epsilon.
9+# declare our dependency on python-dateutil.
10 extra_setup_args = {}
11 try:
12 import setuptools
13 from setuptools import find_packages
14- extra_setup_args['install_requires'] = ['Epsilon']
15+ extra_setup_args['install_requires'] = ['python-dateutil']
16 except ImportError:
17 def find_packages():
18 """
19
20=== modified file 'txaws/s3/client.py'
21--- txaws/s3/client.py 2011-09-22 16:57:38 +0000
22+++ txaws/s3/client.py 2012-01-06 00:05:26 +0000
23@@ -15,7 +15,7 @@
24
25 from twisted.web.http import datetimeToString
26
27-from epsilon.extime import Time
28+from dateutil.parser import parse as parseTime
29
30 from txaws.client.base import BaseClient, BaseQuery, error_wrapper
31 from txaws.s3.acls import AccessControlPolicy
32@@ -96,7 +96,7 @@
33 for bucket_data in root.find("Buckets"):
34 name = bucket_data.findtext("Name")
35 date_text = bucket_data.findtext("CreationDate")
36- date_time = Time.fromISO8601TimeAndDate(date_text).asDatetime()
37+ date_time = parseTime(date_text)
38 bucket = Bucket(name, date_time)
39 buckets.append(bucket)
40 return buckets
41@@ -143,8 +143,7 @@
42 for content_data in root.findall("Contents"):
43 key = content_data.findtext("Key")
44 date_text = content_data.findtext("LastModified")
45- modification_date = Time.fromISO8601TimeAndDate(
46- date_text).asDatetime()
47+ modification_date = parseTime(date_text)
48 etag = content_data.findtext("ETag")
49 size = content_data.findtext("Size")
50 storage_class = content_data.findtext("StorageClass")

Subscribers

People subscribed via source and target branches

to all changes: