Code review comment for lp:~clint-fewbar/pyjuju/namespace-from-env

Revision history for this message
Kapil Thangavelu (hazmat) wrote :

Excerpts from Kapil Thangavelu's message of 2012-03-15 18:07:25 UTC:
> This code would be much simpler, and easier to reason about its
> correctness, if it did all its parsing up front and just used the
> variables instead of conditionally redefining them as it went with
> incremental parsing of 'rest'.
>
>
> https://codereview.appspot.com/5695056/diff/8002/juju/charm/url.py
> File juju/charm/url.py (right):
>
> https://codereview.appspot.com/5695056/diff/8002/juju/charm/url.py#newcode155
> juju/charm/url.py:155: default_infer_series, rest = rest.split('/',1)
> untested
>
> https://codereview.appspot.com/5695056/diff/8002/juju/charm/url.py#newcode182
> juju/charm/url.py:182: rest = "%s/%s" % (default_infer_series, rest)
> untested
>
> https://codereview.appspot.com/5695056/
>

diff to pep8 fixes
http://paste.ubuntu.com/885281/

« Back to merge proposal