Merge lp:~clint-fewbar/pyjuju/ec2-use-ip-address into lp:pyjuju
Proposed by
Clint Byrum
Status: | Work in progress |
---|---|
Proposed branch: | lp:~clint-fewbar/pyjuju/ec2-use-ip-address |
Merge into: | lp:pyjuju |
Diff against target: |
315 lines (+163/-16) 7 files modified
juju/providers/ec2/__init__.py (+2/-1) juju/providers/ec2/launch.py (+8/-1) juju/providers/ec2/machine.py (+30/-4) juju/providers/ec2/tests/common.py (+18/-2) juju/providers/ec2/tests/test_getmachines.py (+4/-0) juju/providers/ec2/tests/test_launch.py (+21/-2) juju/providers/ec2/tests/test_machine.py (+80/-6) |
To merge this branch: | bzr merge lp:~clint-fewbar/pyjuju/ec2-use-ip-address |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Juju Engineering | Pending | ||
Review via email: mp+119021@code.launchpad.net |
Description of the change
Use ipAddress as a fallback for dnsName
Use ipAddress as a fallback if dnsName is unresolvable
To post a comment you must log in.
Unmerged revisions
- 566. By Clint Byrum
-
skip ip_address tests on txaws that does not support it
- 565. By Clint Byrum
-
refactor to do lookup in machine_
from_instance - 564. By Clint Byrum
-
add support for older txaws api
- 563. By Clint Byrum
-
Use ip address when we cannot lookup the hostname given by the provider
This is better than what we have today (per the analysis I provided for use of ips), but it has a significant flaw: many folk have DNS servers (e.g. opendns) that resolve DNS names that don't exist. You'll need a much more complex algorithm to determine 'DNS is broken' than merely fails-to-resolve.