Merge lp:~clint-fewbar/pyjuju/add-policy-no-hardcoded-tools into lp:~charm-contributors/pyjuju/docs

Proposed by Clint Byrum
Status: Merged
Approved by: Juan L. Negron
Approved revision: 73
Merged at revision: 75
Proposed branch: lp:~clint-fewbar/pyjuju/add-policy-no-hardcoded-tools
Merge into: lp:~charm-contributors/pyjuju/docs
Diff against target: 20 lines (+3/-2)
1 file modified
source/policy.rst (+3/-2)
To merge this branch: bzr merge lp:~clint-fewbar/pyjuju/add-policy-no-hardcoded-tools
Reviewer Review Type Date Requested Status
Juan L. Negron (community) Approve
Review via email: mp+130222@code.launchpad.net

Description of the change

Adds policy to prevent hooks from calling tools with hardcoded paths (so you have to call 'relation-get' not '/usr/bin/relation-get')

To post a comment you must log in.
Revision history for this message
Clint Byrum (clint-fewbar) wrote :

This is a policy decision, so please do not merge without a consensus (which I'd define as at least two +1's and no -1's.)

Revision history for this message
Marco Ceppi (marcoceppi) wrote :

+1 from me, seems sensible

Revision history for this message
Robert Ayres (robert-ayres) wrote :

+1 from me

Revision history for this message
Juan L. Negron (negronjl) wrote :

I agree. Approving since three of us agree on this.

-Juan

review: Approve
Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Merged into lp:juju/docs (which is slightly different than the target since it is now owned by ~charmers)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'source/policy.rst'
2--- source/policy.rst 2012-08-15 18:22:32 +0000
3+++ source/policy.rst 2012-10-17 20:43:21 +0000
4@@ -1,6 +1,6 @@
5-:Version: 0.1.1
6+:Version: 0.1.2
7 :Authors: Clint Byrum <clint@ubuntu.com>
8-:Date: August 15, 2012
9+:Date: October 17, 2012
10
11 ==================
12 Charm Store Policy
13@@ -37,6 +37,7 @@
14 * must be under a Free license. license2_
15 * must have hooks that are idempotent idempotent_
16 * must not run any network services using default passwords.
17+* must call juju API tools (relation-*, unit-*, config-*, etc) without a hard coded path.
18 * should default to use software that is included in the Ubuntu archive,
19 however we encourage that charm authors have a config options for
20 allowing users to deploy from newer upstream releases, or even right

Subscribers

People subscribed via source and target branches