Juju Charm Tools

Merge lp:~clint-fewbar/charm-tools/name-must-match-dir into lp:~charmers/charm-tools/trunk

  1. name-must-match-dir
  2. Merge into trunk
Proposed by Clint Byrum on 2012-04-19
Status: Merged
Merged at revision: 131
Proposed branch: lp:~clint-fewbar/charm-tools/name-must-match-dir
Merge into: lp:~charmers/charm-tools/trunk
Diff against target: 14 lines (+4/-0)
1 file modified
scripts/proof (+4/-0)
To merge this branch: bzr merge lp:~clint-fewbar/charm-tools/name-must-match-dir
Reviewer Review Type Date Requested Status
Marco Ceppi 2012-04-19 Approve on 2012-04-19
Review via email: mp+102617@code.launchpad.net

Description of the Change

Add a check for the name: field matching the base dir name.

To post a comment you must log in.
Marco Ceppi (marcoceppi) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'scripts/proof'
2--- scripts/proof 2012-02-08 23:37:52 +0000
3+++ scripts/proof 2012-04-19 03:36:17 +0000
4@@ -126,6 +126,10 @@
5
6 yamlfile.close()
7
8+ charm_basename = path.basename(charm_path)
9+ if charm['name'] != charm_basename:
10+ warn("metadata name (%s) must match directory name (%s) exactly for local deployment." % (charm['name'], charm_basename))
11+
12 # summary should be short
13 if len(charm['summary']) > 72:
14 warn('summary sould be less than 72')

Subscribers

People subscribed via source and target branches