Merge lp:~cleitonfloss/capnet-assist/switch-204-url into lp:~elementary-apps/capnet-assist/trunk

Proposed by Cleiton Floss
Status: Rejected
Rejected by: Cody Garver
Proposed branch: lp:~cleitonfloss/capnet-assist/switch-204-url
Merge into: lp:~elementary-apps/capnet-assist/trunk
Diff against target: 12 lines (+1/-1)
1 file modified
src/CaptiveLogin.vala (+1/-1)
To merge this branch: bzr merge lp:~cleitonfloss/capnet-assist/switch-204-url
Reviewer Review Type Date Requested Status
Cody Garver (community) Disapprove
Review via email: mp+266670@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Cody Garver (codygarver) wrote :

Rejected because this was implemented in packaging so everyone who uses this outside of elementary OS will not be pinging to elementary OS server, android instead.

review: Disapprove

Unmerged revisions

24. By Cleiton Floss

Switch to elementary.io/generate_204

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/CaptiveLogin.vala'
2--- src/CaptiveLogin.vala 2015-06-06 23:51:51 +0000
3+++ src/CaptiveLogin.vala 2015-08-02 16:01:46 +0000
4@@ -52,7 +52,7 @@
5 }
6
7 public bool isLoggedIn () {
8- var page = "http://connectivitycheck.android.com/generate_204";
9+ var page = "http://elementary.io/generate_204";
10 debug ("Getting 204 page");
11
12 var session = new Soup.Session ();

Subscribers

People subscribed via source and target branches

to all changes: