Merge lp:~cldunlap1/ubuntu/oneiric/nss/fix-for-855424 into lp:ubuntu/oneiric/nss

Proposed by Chad Dunlap
Status: Work in progress
Proposed branch: lp:~cldunlap1/ubuntu/oneiric/nss/fix-for-855424
Merge into: lp:ubuntu/oneiric/nss
Diff against target: 26 lines (+7/-1)
2 files modified
debian/changelog (+6/-0)
debian/control (+1/-1)
To merge this branch: bzr merge lp:~cldunlap1/ubuntu/oneiric/nss/fix-for-855424
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
Ubuntu branches Pending
Review via email: mp+78266@code.launchpad.net

Description of the change

I changed a spelling error in debian/control in accordance with LP: #855424.

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Thanks a lot for this bug fix and help to make ubuntu better!

Your change looks good (but it needs to target the current serie, oneiric and even oneiric-proposed now that we are in final freeze).
However, I guess this change can also benefit debian. I'll then just pend it for Precise (the next ubuntu version) and keep it under the radar.
Can you care about pushing back the change to debian? Thanks again for this :)

review: Approve
Revision history for this message
Chad Dunlap (cldunlap1) wrote :

On Friday, October 07, 2011 05:14:25 AM you wrote:
> Review: Approve
>
> Thanks a lot for this bug fix and help to make ubuntu better!
>
> Your change looks good (but it needs to target the current serie, oneiric
> and even oneiric-proposed now that we are in final freeze). However, I
> guess this change can also benefit debian. I'll then just pend it for
> Precise (the next ubuntu version) and keep it under the radar. Can you
> care about pushing back the change to debian? Thanks again for this :)

Do you want me to do the submittodebian? I just need to understand what you
are asking.

--

Thank You,
Chad Dunlap

Revision history for this message
Chad Dunlap (cldunlap1) wrote :

On Friday, October 07, 2011 05:14:25 AM you wrote:
> Review: Approve
>
> Thanks a lot for this bug fix and help to make ubuntu better!
>
> Your change looks good (but it needs to target the current serie, oneiric
> and even oneiric-proposed now that we are in final freeze). However, I
> guess this change can also benefit debian. I'll then just pend it for
> Precise (the next ubuntu version) and keep it under the radar. Can you
> care about pushing back the change to debian? Thanks again for this :)

I am pretty sure I did make this change in Oneiric. When I look for the .deb,
to test the package, it shows up in my pbuilder/oneiric_result/ directory. I
didn't even know there was an oneiric-proposed but I can build that
environment and make the change there if it helps.

I can submit the bug fix to debian if you like.

Just let me know on both accounts. I will wait until I hear back before
proceeding.

--

Thank You,
Chad Dunlap

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Hey Chad,
I just checked and this change is not in done merged in current oneiric. For typo in debian/control, we intend to strongly encourage reporting the bug to debian as well to not carry this kind of diff (in nss, it's a little bit less relevant as it seems we didn't merge for a while back to debian), but it's always better to make everyone benefit from it.

Now, it's something for precise, can you please target it? I will sponsor it as soon as precise is opened!
Thanks again for your work there.

review: Approve
Revision history for this message
Chad Dunlap (cldunlap1) wrote :

On Wednesday, October 12, 2011 03:05:21 AM Didier Roche wrote:
> Review: Approve
>
> Hey Chad,
> I just checked and this change is not in done merged in current oneiric.
> For typo in debian/control, we intend to strongly encourage reporting the
> bug to debian as well to not carry this kind of diff (in nss, it's a
> little bit less relevant as it seems we didn't merge for a while back to
> debian), but it's always better to make everyone benefit from it.
>
> Now, it's something for precise, can you please target it? I will sponsor
> it as soon as precise is opened! Thanks again for your work there.

I can push it to Debian, that isn't a problem. Quick question though, I am
not exactly sure what you mean by 'can you please target it'? I am still kind
of new to this and I truly appreciate the patience that you and the rest of
the team has shown me.

--

Thank You,
Chad Dunlap

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Sorry, didn't see your answer, just push it in debian please, I'll do the right thing for precise (your debian/changelog contains natty where it should use the latest version and contain "precise"). Thanks again!

Revision history for this message
Chad Dunlap (cldunlap1) wrote :

Thanks Didier. I will get going the debian piece. Also, if you want
me to do the precise work, I can. I could use the practice.

On Fri, Oct 21, 2011 at 2:58 AM, Didier Roche <email address hidden> wrote:
> Sorry, didn't see your answer, just push it in debian please, I'll do the right thing for precise (your debian/changelog contains natty where it should use the latest version and contain "precise"). Thanks again!
> --
> https://code.launchpad.net/~cldunlap1/ubuntu/oneiric/nss/fix-for-855424/+merge/78266
> You are the owner of lp:~cldunlap1/ubuntu/oneiric/nss/fix-for-855424.
>

Revision history for this message
Chad Dunlap (cldunlap1) wrote :

Here is the link for the submission to debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=646121

Please let me know if there is anything else you need from me.

I also want to thank you for working through this with me. I have learned a lot from our interactions and your direction.

Unmerged revisions

33. By Chad Dunlap

debian/control: fixed a spelling error. it was 'compatbility', now it is 'compatibility' (LP: #855424)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-09-21 14:42:05 +0000
3+++ debian/changelog 2011-10-05 15:08:25 +0000
4@@ -1,3 +1,9 @@
5+nss (3.12.9+ckbi-1.82-0ubuntu7) natty; urgency=low
6+
7+ * debian/control: fixed a spelling error. it was 'compatbility', now it is 'compatibility' (LP: #855424)
8+
9+ -- Chad Dunlap <cldunlap1@gmail.com> Wed, 05 Oct 2011 10:58:46 -0400
10+
11 nss (3.12.9+ckbi-1.82-0ubuntu6) oneiric; urgency=low
12
13 * No-change rebuild to force a version bump, forcing upgrades,
14
15=== modified file 'debian/control'
16--- debian/control 2011-04-22 18:00:19 +0000
17+++ debian/control 2011-10-05 15:08:25 +0000
18@@ -32,7 +32,7 @@
19 and v4, TLS, PKCS #5, #7, #11, #12, S/MIME, X.509 v3 certificates and
20 other security standards.
21 .
22- This package contains versioned symbolic links for Debian compatbility
23+ This package contains versioned symbolic links for Debian compatibility
24
25 Package: libnss3-tools
26 Section: admin

Subscribers

People subscribed via source and target branches

to all changes: