Merge lp:~cjwatson/unity-scopes-api/lttng-optional into lp:unity-scopes-api

Proposed by Colin Watson
Status: Rejected
Rejected by: Michal Hruby
Proposed branch: lp:~cjwatson/unity-scopes-api/lttng-optional
Merge into: lp:unity-scopes-api
Diff against target: 58 lines (+10/-6)
4 files modified
CMakeLists.txt (+2/-2)
debian/control (+2/-2)
src/scopes/internal/CMakeLists.txt (+3/-1)
test/gtest/scopes/internal/CMakeLists.txt (+3/-1)
To merge this branch: bzr merge lp:~cjwatson/unity-scopes-api/lttng-optional
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Colin Watson Disapprove
Unity Team Pending
Review via email: mp+211357@code.launchpad.net

Commit message

Use LTTng only on architectures where it is available.

Description of the change

Use LTTng only on architectures where it is available. This should let unity-scopes-api build on arm64 and ppc64el.

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :

Withdrawing this; LTTng has been ported to all architectures now.

review: Disapprove
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote :

Hi Colin, could you please either delete this branch or change the status under "Branch information" to Abandoned. Thanks

Unmerged revisions

179. By Colin Watson

Use LTTng only on architectures where it is available.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2014-03-07 11:52:22 +0000
3+++ CMakeLists.txt 2014-03-17 16:22:40 +0000
4@@ -57,10 +57,10 @@
5 find_package(Boost COMPONENTS regex serialization REQUIRED)
6 pkg_check_modules(UNITY_API libunity-api>=0.1.1 REQUIRED)
7 pkg_check_modules(PROCESS_CPP process-cpp REQUIRED)
8-pkg_check_modules(LTTNG_UST lttng-ust REQUIRED)
9+pkg_check_modules(LTTNG_UST lttng-ust)
10 pkg_check_modules(LIBURCU_BP liburcu-bp REQUIRED)
11 find_program(LTTNG_EXECUTABLE lttng)
12-if (NOT LTTNG_EXECUTABLE)
13+if (LTTNG_UST_FOUND AND NOT LTTNG_EXECUTABLE)
14 message(SEND_ERROR "Cannot find LTTng executable: ensure that lttng-tools is installed")
15 endif()
16
17
18=== modified file 'debian/control'
19--- debian/control 2014-03-03 11:50:58 +0000
20+++ debian/control 2014-03-17 16:22:40 +0000
21@@ -16,8 +16,8 @@
22 libcapnp-dev (>= 0.4.0),
23 libzmq3-dev,
24 libzmqpp-dev,
25- liblttng-ust-dev,
26- lttng-tools,
27+ liblttng-ust-dev [amd64 armhf i386 powerpc],
28+ lttng-tools [amd64 armhf i386 powerpc],
29 qtbase5-dev,
30 libjsoncpp-dev,
31 Standards-Version: 3.9.4
32
33=== modified file 'src/scopes/internal/CMakeLists.txt'
34--- src/scopes/internal/CMakeLists.txt 2014-03-07 02:18:16 +0000
35+++ src/scopes/internal/CMakeLists.txt 2014-03-17 16:22:40 +0000
36@@ -1,4 +1,6 @@
37-add_subdirectory(lttng)
38+if(LTTNG_UST_FOUND)
39+ add_subdirectory(lttng)
40+endif()
41 add_subdirectory(smartscopes)
42 add_subdirectory(zmq_middleware)
43 set(CAPNPROTO_FILES ${CAPNPROTO_FILES} PARENT_SCOPE)
44
45=== modified file 'test/gtest/scopes/internal/CMakeLists.txt'
46--- test/gtest/scopes/internal/CMakeLists.txt 2014-02-24 14:56:26 +0000
47+++ test/gtest/scopes/internal/CMakeLists.txt 2014-03-17 16:22:40 +0000
48@@ -2,7 +2,9 @@
49 add_subdirectory(ConfigBase)
50 add_subdirectory(DynamicLoader)
51 add_subdirectory(JsonNode)
52-add_subdirectory(lttng)
53+if(LTTNG_UST_FOUND)
54+ add_subdirectory(lttng)
55+endif()
56 add_subdirectory(MiddlewareFactory)
57 add_subdirectory(Reaper)
58 add_subdirectory(RegistryConfig)

Subscribers

People subscribed via source and target branches

to all changes: