Merge ~cjwatson/txpkgupload:charm-oops-prefix-name into txpkgupload:master

Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: bb897d24dc14384b937a0763d76ab7a6396b07b1
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/txpkgupload:charm-oops-prefix-name
Merge into: txpkgupload:master
Diff against target: 35 lines (+5/-5)
2 files modified
charm/txpkgupload/config.yaml (+4/-4)
charm/txpkgupload/templates/txpkgupload_config.yaml.j2 (+1/-1)
Reviewer Review Type Date Requested Status
Ines Almeida Approve
Guruprasad Approve
Review via email: mp+447184@code.launchpad.net

Commit message

charm: Rename oopses_prefix to oops_prefix

Description of the change

This brings it into line with the `launchpad-base` layer; there's no need to use a different spelling here.

To post a comment you must log in.
Revision history for this message
Guruprasad (lgp171188) wrote :

LGTM 👍

review: Approve
Revision history for this message
Ines Almeida (ines-almeida) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/charm/txpkgupload/config.yaml b/charm/txpkgupload/config.yaml
2index bcfe498..8257478 100644
3--- a/charm/txpkgupload/config.yaml
4+++ b/charm/txpkgupload/config.yaml
5@@ -3,6 +3,10 @@ options:
6 type: int
7 default: 2221
8 description: The port to run the FTP server on.
9+ oops_prefix:
10+ type: string
11+ default: local
12+ description: The prefix used when generating OOPS reports.
13 sftp_authentication_endpoint:
14 type: string
15 default: http://xmlrpc-private.launchpad.dev:8087/authserver
16@@ -19,7 +23,3 @@ options:
17 type: int
18 default: 5023
19 description: The port to run the SFTP server on.
20- oopses_prefix:
21- type: string
22- default: local
23- description: The prefix used when generating OOPS reports.
24diff --git a/charm/txpkgupload/templates/txpkgupload_config.yaml.j2 b/charm/txpkgupload/templates/txpkgupload_config.yaml.j2
25index ebfa052..78b1edb 100644
26--- a/charm/txpkgupload/templates/txpkgupload_config.yaml.j2
27+++ b/charm/txpkgupload/templates/txpkgupload_config.yaml.j2
28@@ -9,7 +9,7 @@ sftp:
29
30 oops:
31 directory: "{{ oopses_dir }}"
32- reporter: "{{ oopses_prefix }}"
33+ reporter: "{{ oops_prefix }}"
34
35 access_log: "{{ logs_dir }}/txpkgupload-access.log"
36

Subscribers

People subscribed via source and target branches

to all changes: