Merge ~cjwatson/turnip:use-pip-cache into turnip:master
Proposed by
Colin Watson
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | ca8e6ac76b22772a402bb4d29c55b8122e173f09 |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~cjwatson/turnip:use-pip-cache |
Merge into: | turnip:master |
Diff against target: |
45 lines (+13/-6) 1 file modified
Makefile (+13/-6) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Thiago F. Pappacena (community) | Approve | ||
Review via email: mp+399717@code.launchpad.net |
Commit message
Actually use pip cache at build time
Description of the change
turnip's Makefile was building a pip cache, but inexplicably not actually using it at build time. On my laptop, using the pip cache takes the build time on my laptop (removing ~/.cache/pip/ before each test) from 8m3s to 31s.
In the process, I switched to configuring pip using environment variables; this is more reliable, as environment variables are passed through to pip processes run by setuptools when handling setup_requires.
I suspect this is a large part of why turnip code asset deployments have been so slow.
To post a comment you must log in.
LGTM