Merge ~cjwatson/turnip:fix-rabbitmq-hooks into turnip:master
Proposed by
Colin Watson
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | c5ab05edf6dbb775d45bd431b22abc6b303acfae |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~cjwatson/turnip:fix-rabbitmq-hooks |
Merge into: | turnip:master |
Diff against target: |
182 lines (+37/-37) 5 files modified
charm/layer/turnip-base/lib/charms/turnip/base.py (+3/-8) charm/turnip-api/lib/charms/turnip/api.py (+1/-5) charm/turnip-api/reactive/turnip-api.py (+15/-8) charm/turnip-celery/lib/charms/turnip/celery.py (+2/-8) charm/turnip-celery/reactive/turnip-celery.py (+16/-8) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Thiago F. Pappacena (community) | Approve | ||
Review via email: mp+389630@code.launchpad.net |
Commit message
charm: Fix handling of rabbitmq relations
Description of the change
Avoid trying to start turnip-celery when its code and storage prerequisites are potentially unavailable.
Rearrange how we request access to rabbitmq. Using the 'available' state provided by the rabbitmq interface means we can guarantee that the broker URL will always be available at that point, simplifying configuration. To ensure that things work if the rabbitmq relation is removed and re-added, we must explicitly clear any previous access request so that the rabbitmq-server charm notices that the relation data has changed.
To post a comment you must log in.
LGTM