Merge ~cjwatson/turnip:loseWriteConnection-test-failure into turnip:master
Proposed by
Colin Watson
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | 657ecf170fb2f1d85cae2d2ce6f07676a5e2ca8c |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~cjwatson/turnip:loseWriteConnection-test-failure |
Merge into: | turnip:master |
Diff against target: |
25 lines (+3/-2) 2 files modified
turnip/pack/git.py (+1/-1) turnip/pack/ssh.py (+2/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Colin Watson (community) | Approve | ||
Tom Wardill (community) | Approve | ||
Review via email: mp+357691@code.launchpad.net |
Commit message
Check if transport is connected before closing it
We've seen occasional test failures in `loseWriteConne
some time because the socket had already been closed, and they've become
much more frequent of late. Checking whether the transport is still
connected before telling it to lose its write connection should help.
LP: #1641100
To post a comment you must log in.
Voting criteria not met /jenkins. ols.canonical. com/online- services/ job/turnip/ 40/
https:/