Merge lp:~cjwatson/turku/turku-storage-preserve-hard-links into lp:turku

[Colin Watson]

Add a configuration option to preserve hard links.

This can be expensive, so we shouldn't do it for every source. However, the git service uses hard links when creating subordinate repositories, and not preserving these may cause a significant amount of backup bloat.

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

[Colin Watson (cjwatson)]

This is for https://portal.admin.canonical.com/C122244.

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

Change successfully merged at revision 36

=== modified file 'turku_storage/ping.py'
--- turku_storage/ping.py	2019-05-22 17:35:00 +0000
+++ turku_storage/ping.py	2019-10-29 10:14:53 +0000
@@ -202,6 +202,8 @@
                     rsync_args.append('--link-dest=%s' % os.path.join(snapshot_dir, base_snapshot))
             else:
                 rsync_args.append('--inplace')
+            if self.config['preserve_hard_links']:
+                rsync_args.append('--hard-links')
 
             filter_file = None
             filter_data = ''
 
=== modified file 'turku_storage/utils.py'
--- turku_storage/utils.py	2019-05-22 17:35:00 +0000
+++ turku_storage/utils.py	2019-10-29 10:14:53 +0000
@@ -188,6 +188,8 @@
 
     if 'snapshot_mode' not in config:
         config['snapshot_mode'] = 'link-dest'
+    if 'preserve_hard_links' not in config:
+        config['preserve_hard_links'] = False
 
     if 'ssh_ping_host' not in config:
         config['ssh_ping_host'] = socket.getfqdn()