Merge lp:~cjwatson/storm/py3-final into lp:storm

[Colin Watson]

Document Python 3 support.

Now that all the Python 3 support branches have landed, we can document it and adjust tox configuration to ensure that it keeps working.

[Simon Poirier (simpoir)]

+1 LGTM

review: Approve

=== modified file '.bzrignore'
--- .bzrignore	2019-05-30 13:21:20 +0000
+++ .bzrignore	2019-09-17 09:46:46 +0000
@@ -1,3 +1,4 @@
+__pycache__
 build
 storm.egg-info
 build-stamp

=== modified file 'NEWS'
--- NEWS	2019-08-11 17:51:37 +0000
+++ NEWS	2019-09-17 09:46:46 +0000
@@ -12,6 +12,21 @@
   both StormError and the appropriate DB-API exception type, rather than
   injecting virtual base classes. This preserves existing exception handling
   in applications while also being a viable approach in Python 3.
+- Port to Python 3 (bug #1530734, based partly on contributions from Thiago
+  Bellini).  Existing Python 2 users should be unaffected.  For people
+  porting to Python 3, note the following API changes relative to Python 2:
+  - On Python 3, raw=True and token=True in storm.expr.Compile.__call__ only
+    treat str specially, not bytes and str, because ultimately the compiler
+    is assembling a text string to send to the database.
+  - On Python 3, storm.tracer.BaseStatementTracer.connection_raw_execute
+    renders text parameters using ascii() rather than by encoding to bytes
+    and then calling repr().  While this does result in slightly different
+    output from Python 2, it's normally more useful since the encoding is in
+    terms of Unicode codepoints rather than UTF-8.
+  - storm.sqlobject.AutoUnicodeVariable (and hence StringCol) explicitly
+    documents that it only accepts text on Python 3, since native strings
+    are already Unicode there so there's much less need for the porting
+    affordance.
 
 Bug fixes
 ---------

=== modified file 'setup.py'
--- setup.py	2019-08-11 17:51:37 +0000
+++ setup.py	2019-09-17 09:46:46 +0000
@@ -58,6 +58,8 @@
         ("License :: OSI Approved :: GNU Library or "
          "Lesser General Public License (LGPL)"),
         "Programming Language :: Python",
+        "Programming Language :: Python :: 2",
+        "Programming Language :: Python :: 3",
         "Topic :: Database",
         "Topic :: Database :: Front-Ends",
         "Topic :: Software Development :: Libraries :: Python Modules",

=== modified file 'tox.ini'
--- tox.ini	2019-06-06 10:25:25 +0000
+++ tox.ini	2019-09-17 09:46:46 +0000
@@ -1,6 +1,7 @@
 [tox]
 envlist =
     py27-{cextensions,nocextensions}
+    py35-{cextensions,nocextensions}
 
 [testenv]
 deps =