Storm

Merge lp:~cjwatson/storm/improve-mysql-db-setup into lp:storm

  1. improve-mysql-db-setup
  2. Merge into trunk
Proposed by Colin Watson
Status: Rejected
Rejected by: Adam Collard
Proposed branch: lp:~cjwatson/storm/improve-mysql-db-setup
Merge into: lp:storm
Diff against target: 16 lines (+4/-1)
1 file modified
dev/db-setup (+4/-1)
To merge this branch: bzr merge lp:~cjwatson/storm/improve-mysql-db-setup
Reviewer Review Type Date Requested Status
Colin Watson Disapprove
Storm Developers Pending
Review via email: mp+368073@code.launchpad.net

Commit message

Fix setup of MySQL test user in dev/db-setup.

Description of the change

This makes db-setup work in a fresh container.

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :

Superseded by https://code.launchpad.net/~ack/storm/drop-mysql-support/+merge/288652.

review: Disapprove

Unmerged revisions

486. By Colin Watson

Fix setup of MySQL test user in dev/db-setup.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'dev/db-setup'
2--- dev/db-setup 2013-02-26 21:39:56 +0000
3+++ dev/db-setup 2019-05-29 15:20:42 +0000
4@@ -37,8 +37,11 @@
5 # If this fails, we will get errors later, so don't fail.
6 sudo -u postgres createuser --superuser $USER || /bin/true
7
8+echo " * Create mysql user ($USER - will fail if existing)"
9+sudo mysql -u root -e "CREATE USER '$USER'@'localhost' IDENTIFIED BY '';" || /bin/true
10+
11 echo " * Granting all mysql privs to $USER"
12-mysql -u root -e "$MYSQL_PRIVS"
13+sudo mysql -u root -e "$MYSQL_PRIVS"
14
15 echo " * Create DB Test Fixtures (will fail if existing)"
16 createdb storm_test || /bin/true

Subscribers

People subscribed via source and target branches

to status/vote changes: