lp:~cjwatson/storm/clarify-no-allow-none-default-none-exception

Branch merges

Propose for merging

Merged into lp:storm at revision 576

Ioana Lasc (community): Approve on 2022-03-17

Diff: 168 lines (+64/-16)

6 files modified

NEWS (+6/-0)
storm/cextensions.c (+9/-0)
storm/tests/mocker.py (+4/-0)
storm/tests/properties.py (+8/-0)
storm/tests/variables.py (+30/-13)
storm/variables.py (+7/-3)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

576. By Colin Watson on 2022-03-16

Clarify exception for a property with allow_none=False and default=None.

Creating a property with `allow_none=False, default=None` doesn't make
sense, but it's sometimes easy to set things up that way by accident
during refactoring. Storm immediately raises `NoneError` when creating
the variable in that case. However, it's not obvious that the exception
is due to the bad default, and I spent some time with a colleague today
debugging a situation that turned out to be due to this.

Change the exception message from "None isn't acceptable as a value" to
"None isn't acceptable as a default value" in this case, to clue future
travellers into the fact that the problem relates to the default.

575. By Colin Watson on 2021-12-14

[r=cjwatson] Fix a typo in the tutorial doctest code block

574. By Colin Watson on 2021-05-25

[r=ilasc] Fix test compatibility with MySQL >= 8.0.24.

573. By Colin Watson on 2021-05-14

Bump version to 0.25.0.99.

572. By Colin Watson on 2021-05-14

Avoid traceback reference cycles when wrapping exceptions. [r=ilasc]

571. By Colin Watson on 2021-04-19

Release Storm 0.25.

570. By Colin Watson on 2021-04-19

Fix MANIFEST.in prune syntax.

569. By Colin Watson on 2021-04-19

[r=ilasc] Support Python 3.9.

568. By Colin Watson on 2021-04-15

[r=ilasc] Restore MySQL support.

567. By Colin Watson on 2021-04-15

[r=ilasc] Fix py27 and py35 tox environments.