Merge ~cjwatson/snapstore-client:snaprevs-endpoint-names into snapstore-client:master

Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: c5e5edc37a2b842a946cca6e1e474b65461735bc
Merged at revision: c5e5edc37a2b842a946cca6e1e474b65461735bc
Proposed branch: ~cjwatson/snapstore-client:snaprevs-endpoint-names
Merge into: snapstore-client:master
Diff against target: 31 lines (+3/-3)
1 file modified
siab_client/webservices.py (+3/-3)
Reviewer Review Type Date Requested Status
Matt Goodall (community) Approve
Review via email: mp+325998@code.launchpad.net

Commit message

Update snaprevs API URLs

To post a comment you must log in.
Revision history for this message
Matt Goodall (matt-goodall) wrote :

Looks good, matches URL changes in the linked commit.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/siab_client/webservices.py b/siab_client/webservices.py
2index 3d7f1b5..6747302 100644
3--- a/siab_client/webservices.py
4+++ b/siab_client/webservices.py
5@@ -85,7 +85,7 @@ def release_revision(snap_id, snap_name, series, channel, arches,
6 reqs.append(d)
7 revs_root = config.read_config()['services']['snaprevs']
8 resp = requests.post(
9- urllib.parse.urljoin(revs_root, '/release-snaps'),
10+ urllib.parse.urljoin(revs_root, '/channelmaps/update'),
11 json={
12 'developer_id': 'wgrant',
13 'release_requests': reqs,
14@@ -109,7 +109,7 @@ def get_latest_revision_for_snap_id(snap_id):
15 """
16 snaprevs_root = config.read_config()['services']['snaprevs']
17 resp = requests.post(
18- urllib.parse.urljoin(snaprevs_root, '/fetch-revisions'),
19+ urllib.parse.urljoin(snaprevs_root, '/revisions/filter'),
20 json={'filters': [{'snap_id': snap_id}]}
21 )
22 revisions = [s['revision'] for s in resp.json()['revisions']]
23@@ -144,7 +144,7 @@ def create_revision(snap_id, revision, architectures, binary_path, filesize,
24 'type': 'app',
25 }
26 resp = requests.post(
27- urllib.parse.urljoin(snaprevs_root, '/create-revisions'),
28+ urllib.parse.urljoin(snaprevs_root, '/revisions/create'),
29 json=[payload]
30 )
31 if resp.status_code != 201:

Subscribers

People subscribed via source and target branches

to all changes: