Merge lp:~cjwatson/rabbitfixture/fix-esrch-handling into lp:rabbitfixture

[Colin Watson]

Fix ignoring of ESRCH errors in RabbitServerRunner._signal.

"If ESRCH do nothing and then raise anyway" is not quite what I meant to type.

[Colin Watson (cjwatson)]

I'm going to go ahead and self-approve this, since it's a very straightforward logic fix.

review: Approve

=== modified file 'NEWS.rst'
--- NEWS.rst	2022-09-01 00:01:34 +0000
+++ NEWS.rst	2022-09-01 11:50:31 +0000
@@ -8,6 +8,7 @@
 - Only send ``SIGTERM`` once while stopping ``RabbitServerRunner``, since
   it's sent to the whole process group and that can itself interfere with
   the shutdown process if we send it frequently and repeatedly.
+- Fix ignoring of ``ESRCH`` errors in ``RabbitServerRunner._signal``.
 
 0.5.1 (2022-07-22)
 ==================

=== modified file 'rabbitfixture/server.py'
--- rabbitfixture/server.py	2022-09-01 00:01:34 +0000
+++ rabbitfixture/server.py	2022-09-01 11:50:31 +0000
@@ -471,9 +471,8 @@
         try:
             os.killpg(os.getpgid(self.process.pid), code)
         except OSError as e:
-            if e.errno == errno.ESRCH:
-                pass
-            raise
+            if e.errno != errno.ESRCH:
+                raise
 
 
 class RabbitServer(Fixture):