Merge lp:~cjwatson/qml-friends/avoid-friends-dependency into lp:qml-friends

[Colin Watson]

Break old versions of friends rather than depending on new ones, to avoid pulling the friends run-time into cross-building chroots.

qml-friends 0.1.0bzr13.03.20.1-0ubuntu1 added "Depends: friends (>= 0.1.3)" to cope with a schema change in friends. Previously, qml-friends didn't depend on the friends run-time at all, and usually I'd expect bindings only to depend on the library interface rather than the run-time service. For the stated purpose, "Breaks: friends (<< 0.1.3)" would be a more precise way to state it: it ensures that friends is upgraded to >= 0.1.3 if installed, but doesn't require it to be installed.

The reason I care is that I'm trying to get "ubuntu-sdk-libs-dev:armhf" to be installable inside "click chroot" for the purpose of cross-building. We typically want the full set of phone-relevant QML bindings to be installed here. Run-time services are unnecessary and unwanted, but they're normally harmless since we disable daemon startup inside "click chroot". However, in this case it isn't harmless, because friends depends on a number of gir* packages via friends-dispatcher. gir* packages aren't currently multiarch-capable: the .typelib files differ across architectures but there's only one path available for their installation. This should probably be fixed, but it will take time. In the meantime, we need to be extra-careful to avoid requiring run-time services to be installed together with development packages, because that will cause an irreconcilable conflict in terms of which gir* packages should be installed.

This isn't the only problem like this: libfriends0 depends on friends-dispatcher too, which poses a similar problem. I'll work on that separately. However, there's a small enough number of these problems that I think we can fix them all in time to use "ubuntu-sdk-libs-dev:armhf" in "click chroot" for 14.04.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:62
http://jenkins.qa.ubuntu.com/job/qml-friends-ci/23/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qml-friends-trusty-amd64-ci/5

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qml-friends-ci/23/rebuild

review: Approve (continuous-integration)

[Robert Bruce Park (robru)]

I'm inclined to defer to your judgement here, but I would like to point out that qml-friends really does depend on friends. The frontend UI is provided by friends-app, 'friends' (particularly friends-dispatcher) really is the backend "library" and qml-friends is just a bridge between the two. So qml-friends really will not function without friends-dispatcher in place to respond to it's dbus calls.

As you say this is a workaround for a multiarch issue, but at the very least you'll need to make sure that friends-app depends on qml-friends and friends (-dispatcher, -service) in order to actually function properly on any arch/platform.

[Robert Bruce Park (robru)]

Just double-checked, friends-app doesn't depend on friends, only qml-friends:

http://bazaar.launchpad.net/~super-friends/friends-app/trunk/view/head:/debian/control

So that'll need to be fixed before I can accept this MP.

review: Needs Fixing

[Robert Bruce Park (robru)]

Hm, this slipped through the cracks. Is this still relevant in light of the Friends' neutering? I'm not sure whether to reject this or whether to make friends-app depend on friends-dispatcher and then accept this.

review: Needs Information

Unmerged revisions

62. By Colin Watson on 2014-03-27

Break old versions of friends rather than depending on new ones, to avoid pulling the friends run-time into cross-building chroots.

=== modified file 'debian/control'
--- debian/control	2014-03-17 23:19:36 +0000
+++ debian/control	2014-03-27 10:23:53 +0000
@@ -35,10 +35,10 @@
 Package: qtdeclarative5-friends0.2
 Section: libs
 Architecture: any
-Depends: friends (>= 0.1.3),
-         ${misc:Depends},
+Depends: ${misc:Depends},
          ${shlibs:Depends},
-Breaks: qml2-friends0 (<= 0.1.0bzr13.02.22),
+Breaks: friends (<< 0.1.3),
+        qml2-friends0 (<= 0.1.0bzr13.02.22),
 Replaces: qml2-friends0 (<= 0.1.0bzr13.02.22),
 Provides: qml2-friends0,
 Description: QML Bindings for the Friends library