lp-mailman

Merge ~cjwatson/lp-mailman:fix-tarball into lp-mailman:master

  1. Git
  2. lp:~cjwatson/lp-mailman
  3. fix-tarball
  4. Merge into master
Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: b3803a193afa8e7867384dc39c0cb9deef6de340
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/lp-mailman:fix-tarball
Merge into: lp-mailman:master
Diff against target: 54 lines (+8/-2)
3 files modified
.gitignore (+1/-0)
Makefile (+4/-2)
utilities/build-tarball (+3/-0)
Reviewer Review Type Date Requested Status
Jürgen Gmach Approve
Review via email: mp+452251@code.launchpad.net

Commit message

Make deployment tarball more complete

Description of the change

The tarball we were building omitted the actual Mailman code, and so failed to build on deployed systems; it was also constructed in such a way that we ended up trying to pull the dependencies repository again unnecessarily. This change produces tarballs that we can actually deploy.

To post a comment you must log in.
Revision history for this message
Jürgen Gmach (jugmac00) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/.gitignore b/.gitignore
2index 6e60468..4893d7e 100644
3--- a/.gitignore
4+++ b/.gitignore
5@@ -35,3 +35,4 @@ callgrind.out.*
6 !logs/README.txt
7 /logs
8 /wheels
9+/.bootstrapped
10diff --git a/Makefile b/Makefile
11index ad7ce32..edb8961 100644
12--- a/Makefile
13+++ b/Makefile
14@@ -8,7 +8,7 @@ PY=$(WD)/bin/py
15 PYTHONPATH:=$(WD)/lib:${PYTHONPATH}
16 VERBOSITY=-vv
17
18-DEPENDENCY_REPO ?= lp:~launchpad/lp-mailman/+git/dependencies
19+DEPENDENCY_REPO ?= https://git.launchpad.net/~launchpad/lp-mailman/+git/dependencies
20 DEPENDENCY_DIR ?= $(WD)/download-cache
21
22 # virtualenv and pip fail if setlocale fails, so force a valid locale.
23@@ -86,7 +86,8 @@ build: compile
24 # Create or update $(DEPENDENCY_DIR) if possible. If the directory exists
25 # but isn't a git repository, then assume that we're doing a deployment and
26 # have already been provided with a suitable dependencies directory.
27-bootstrap:
28+bootstrap: .bootstrapped
29+.bootstrapped:
30 if [ -d $(DEPENDENCY_DIR)/.git ]; then \
31 git -C $(DEPENDENCY_DIR) pull; \
32 elif [ -d $(DEPENDENCY_DIR) ]; then \
33@@ -95,6 +96,7 @@ bootstrap:
34 git clone $(DEPENDENCY_REPO) $(DEPENDENCY_DIR); \
35 fi
36 utilities/update-sourcecode
37+ touch $@
38
39 # LP_SOURCEDEPS_PATH should point to the sourcecode directory, but we
40 # want the parent directory where the download-cache and env directories
41diff --git a/utilities/build-tarball b/utilities/build-tarball
42index 0bb7df0..3ca78b8 100755
43--- a/utilities/build-tarball
44+++ b/utilities/build-tarball
45@@ -27,6 +27,9 @@ echo "Creating deployment tarball in $output_dir"
46 mkdir -p "$output_dir"
47 (
48 git ls-files | sed 's,^,./,'
49+ bzr ls -d sourcecode/mailman -R | sed 's,^,./sourcecode/mailman/,'
50+ # Deployments shouldn't bootstrap again.
51+ echo ./.bootstrapped
52 echo ./version-info.py
53 find ./wheels/ -name \*.whl -print
54 ) | sort >"$output_dir/.files"

Subscribers

People subscribed via source and target branches