Launchpad code imports

Merge ~cjwatson/lp-codeimport:flake8-6.1.0 into lp-codeimport:master

  1. Git
  2. lp:~cjwatson/lp-codeimport
  3. flake8-6.1.0
  4. Merge into master
Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 1b00ffabb2caf6ed393b695243e7f738d7bbc63f
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/lp-codeimport:flake8-6.1.0
Merge into: lp-codeimport:master
Diff against target: 25 lines (+1/-2)
2 files modified
.pre-commit-config.yaml (+1/-1)
lib/lp/services/scripts/base.py (+0/-1)
Reviewer Review Type Date Requested Status
Simone Pelosi Approve
Review via email: mp+452535@code.launchpad.net

Commit message

pre-commit: Update to flake8 6.1.0

Description of the change

This spotted an unused assignment shadowed by a property.

To post a comment you must log in.
Revision history for this message
Simone Pelosi (pelpsi) wrote :

LGTM!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
2index 6cb6e67..e631592 100644
3--- a/.pre-commit-config.yaml
4+++ b/.pre-commit-config.yaml
5@@ -12,7 +12,7 @@ repos:
6 exclude: systemdocs\.py
7 - id: no-commit-to-branch
8 - repo: https://github.com/PyCQA/flake8
9- rev: 6.0.0
10+ rev: 6.1.0
11 hooks:
12 - id: flake8
13 exclude: ^lib/contrib/
14diff --git a/lib/lp/services/scripts/base.py b/lib/lp/services/scripts/base.py
15index 55d7ff0..813bb2c 100644
16--- a/lib/lp/services/scripts/base.py
17+++ b/lib/lp/services/scripts/base.py
18@@ -116,7 +116,6 @@ class LaunchpadScript:
19 txn = None
20 usage = None
21 description = None
22- lockfilepath = None
23 loglevel = logging.INFO
24
25 # State for the log_unhandled_exceptions decorator.

Subscribers

People subscribed via source and target branches