Merge ~cjwatson/lp-codeimport:charm-fix-part-name into lp-codeimport:master

Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 70bea475d457ea519155222a48b72391c80269f1
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/lp-codeimport:charm-fix-part-name
Merge into: lp-codeimport:master
Diff against target: 31 lines (+18/-0)
1 file modified
charm/lp-codeimport/config.yaml (+18/-0)
Reviewer Review Type Date Requested Status
Guruprasad Approve
Review via email: mp+448507@code.launchpad.net

Commit message

charm: Add type/description to overridden install_sources/install_keys

Description of the change

Copied from `layer-apt/config.yaml`. `charmcraft` seems to be a bit pickier about this nowadays and is failing if we try to override just the default values.

To post a comment you must log in.
Revision history for this message
Guruprasad (lgp171188) wrote :

LGTM 👍

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/charm/lp-codeimport/config.yaml b/charm/lp-codeimport/config.yaml
2index 9b38fb9..7bffb34 100644
3--- a/charm/lp-codeimport/config.yaml
4+++ b/charm/lp-codeimport/config.yaml
5@@ -87,8 +87,26 @@ options:
6 the nrpe subordinate charm to set up /etc/rsyncd.conf properly.
7 # layer-apt
8 install_sources:
9+ type: string
10 default: |
11 - ppa:launchpad/ppa
12+ description: >
13+ List of extra apt sources, per charm-helpers standard
14+ format (a yaml list of strings encoded as a string). Each source
15+ may be either a line that can be added directly to
16+ sources.list(5), or in the form ppa:<user>/<ppa-name> for adding
17+ Personal Package Archives, or a distribution component to enable.
18 install_keys:
19+ type: string
20 default: |
21 - null # PPA keys securely added via Launchpad.
22+ description: >
23+ List of signing keys for install_sources package sources, per
24+ charmhelpers standard format (a yaml list of strings encoded as
25+ a string). The keys should be the full ASCII armoured GPG public
26+ keys. While GPG key ids are also supported and looked up on a
27+ keyserver, operators should be aware that this mechanism is
28+ insecure. null can be used if a standard package signing key is
29+ used that will already be installed on the machine, and for PPA
30+ sources where the package signing key is securely retrieved from
31+ Launchpad.

Subscribers

People subscribed via source and target branches