Merge ~cjwatson/lp-codeimport:git-auth-launchpad-services into lp-codeimport:master
Proposed by
Colin Watson
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | fc97f28e19894c0096ee0efb0fee0ba34f3b8515 |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~cjwatson/lp-codeimport:git-auth-launchpad-services |
Merge into: | lp-codeimport:master |
Diff against target: |
22 lines (+2/-3) 1 file modified
lib/lp/codehosting/codeimport/worker.py (+2/-3) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ioana Lasc (community) | Approve | ||
Review via email: mp+417643@code.launchpad.net |
Commit message
Authenticate using +launchpad-services rather than empty username
Description of the change
We previously authenticated to git using the empty username and a non-user-bound macaroon. This is syntactically valid and works with current versions of git and curl, but it's the sort of edge case in the URL specification that's easy to mishandle, and modern versions of git built against versions of curl prior to 7.62.0 fail to send an Authorization header. Using a reserved username is safer.
See also the similar https:/
To post a comment you must log in.