Merge lp:~cjwatson/loggerhead/view-fix-line-height into lp:loggerhead

Proposed by Colin Watson on 2019-06-20
Status: Merged
Merged at revision: 493
Proposed branch: lp:~cjwatson/loggerhead/view-fix-line-height
Merge into: lp:loggerhead
Diff against target: 25 lines (+4/-0)
2 files modified
NEWS (+3/-0)
loggerhead/static/css/view.css (+1/-0)
To merge this branch: bzr merge lp:~cjwatson/loggerhead/view-fix-line-height
Reviewer Review Type Date Requested Status
Tom Wardill 2019-06-20 Approve on 2019-06-20
Review via email: mp+369102@code.launchpad.net

Commit message

Set line-height on <pre> elements in file views.

Description of the change

This fixes misaligned line numbers in some browsers, e.g. Firefox; I think the browser was picking a different default line-height for empty vs. non-empty lines.

To post a comment you must log in.
Tom Wardill (twom) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'NEWS'
--- NEWS 2015-03-17 11:38:32 +0000
+++ NEWS 2019-06-20 16:20:26 +0000
@@ -27,6 +27,9 @@
27 - Add some more minor UI changes to do with rounded corners. (Cruz27 - Add some more minor UI changes to do with rounded corners. (Cruz
28 Bishop)28 Bishop)
2929
30 - Set line-height on <pre> elements in file views, fixing misaligned
31 line numbers in some browsers. (Colin Watson)
32
301.18.2 [12Sep2012]331.18.2 [12Sep2012]
31------------------34------------------
3235
3336
=== modified file 'loggerhead/static/css/view.css'
--- loggerhead/static/css/view.css 2012-03-19 04:37:07 +0000
+++ loggerhead/static/css/view.css 2019-06-20 16:20:26 +0000
@@ -28,6 +28,7 @@
28.viewLine pre,28.viewLine pre,
29.viewCont pre {29.viewCont pre {
30 font-family: 'UbuntuBeta Mono', 'Ubuntu Mono', monospace;30 font-family: 'UbuntuBeta Mono', 'Ubuntu Mono', monospace;
31 line-height: 1.1;
31 }32 }
32.viewLine pre {33.viewLine pre {
33 text-align: right;34 text-align: right;

Subscribers

People subscribed via source and target branches