Merge lp:~cjwatson/lazr.restful/py3-html-entry-sort-by-name into lp:lazr.restful

[Colin Watson]

Sort fields in HTML views of entries by name.

The old code caused test failures on Python 3, since dicts are no longer orderable.

[Thiago F. Pappacena (pappacena)]

LGTM

review: Approve

=== modified file 'NEWS.rst'
--- NEWS.rst	2021-01-20 11:23:16 +0000
+++ NEWS.rst	2021-01-20 23:54:56 +0000
@@ -18,6 +18,8 @@
 ``lazr.restful.testing.webservice.pprint_collection`` recurse into lists in
 order to print text string representations in the Python 3 style.
 
+Sort fields in HTML views of entries by name.
+
 0.23.0 (2020-09-28)
 ===================
 

=== modified file 'src/lazr/restful/_resource.py'
--- src/lazr/restful/_resource.py	2020-09-24 10:01:25 +0000
+++ src/lazr/restful/_resource.py	2021-01-20 23:54:56 +0000
@@ -33,6 +33,7 @@
 from datetime import datetime, date
 from email.utils import formatdate
 import copy
+from operator import itemgetter
 import os
 import simplejson
 import simplejson.encoder
@@ -988,7 +989,7 @@
             HTTPResource.XHTML_TYPE).items()
         data = [{'name' : name, 'value': decode_value(value)}
                 for name, value in names_and_values]
-        namespace['context'] = sorted(data)
+        namespace['context'] = sorted(data, key=itemgetter('name'))
         return self.HTML_TEMPLATE.pt_render(namespace)