Merge ~cjwatson/lazr.restful:remove-six into lazr.restful:main
Proposed by
Colin Watson
Status: | Merged |
---|---|
Merged at revision: | 6614e9088b62aca53bfb52ca13259dd34529492a |
Proposed branch: | ~cjwatson/lazr.restful:remove-six |
Merge into: | lazr.restful:main |
Diff against target: |
242 lines (+26/-29) 8 files modified
setup.py (+0/-1) src/lazr/restful/debug.py (+1/-2) src/lazr/restful/declarations.py (+1/-2) src/lazr/restful/docs/webservice.rst (+14/-10) src/lazr/restful/example/base/tests/collection.txt (+1/-3) src/lazr/restful/example/base/tests/entry.txt (+1/-3) src/lazr/restful/testing/helpers.py (+1/-2) src/lazr/restful/testing/webservice.py (+7/-6) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jürgen Gmach | Approve | ||
Review via email: mp+414022@code.launchpad.net |
Commit message
Remove remaining uses of six
To post a comment you must log in.
It is a bit unfortunate that we do not run coverage for this project (and all projects).
Some occurrences of `six.ensure_str` were just removed, some were replaced by xxx.decode().
I cannot say whether this is correct or not.
I quickly tried to setup coverage for the review, the tests ran, but got a "no data collected" error :-/
```
[testenv]
deps =
.[test,xml]
zope.testrunner
coverage
commands =
coverage run -m zope.testrunner --test-path src --tests-pattern ^tests {posargs}
coverage report -m
```
I have no clue what is going wrong here.