Merge ~cjwatson/lazr.restful:remove-six-moves into lazr.restful:main

Proposed by Colin Watson
Status: Merged
Merged at revision: 9086d701e62d10fb64f53ff846cafbf9d184e6a3
Proposed branch: ~cjwatson/lazr.restful:remove-six-moves
Merge into: lazr.restful:main
Diff against target: 265 lines (+25/-25)
16 files modified
src/lazr/restful/docs/multiversion.rst (+1/-1)
src/lazr/restful/docs/webservice-declarations.rst (+2/-2)
src/lazr/restful/docs/webservice.rst (+2/-2)
src/lazr/restful/example/base/tests/collection.txt (+1/-1)
src/lazr/restful/example/base/tests/entry.txt (+1/-1)
src/lazr/restful/example/base/tests/field.txt (+1/-1)
src/lazr/restful/example/base/tests/hostedfile.txt (+1/-1)
src/lazr/restful/example/base/tests/representation-cache.txt (+1/-1)
src/lazr/restful/example/base/tests/service.txt (+1/-1)
src/lazr/restful/example/base/tests/wadl.txt (+1/-1)
src/lazr/restful/example/base/traversal.py (+2/-2)
src/lazr/restful/marshallers.py (+1/-1)
src/lazr/restful/publisher.py (+3/-3)
src/lazr/restful/simple.py (+2/-2)
src/lazr/restful/tales.py (+1/-1)
src/lazr/restful/testing/webservice.py (+4/-4)
Reviewer Review Type Date Requested Status
Jürgen Gmach Approve
Review via email: mp+413797@code.launchpad.net

Commit message

Remove uses of six.moves

To post a comment you must log in.
Revision history for this message
Jürgen Gmach (jugmac00) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/lazr/restful/docs/multiversion.rst b/src/lazr/restful/docs/multiversion.rst
2index 6f3fd68..8a3faca 100644
3--- a/src/lazr/restful/docs/multiversion.rst
4+++ b/src/lazr/restful/docs/multiversion.rst
5@@ -163,7 +163,7 @@ contacts.
6
7 Here's a simple implementation of IContact.
8
9- >>> from six.moves.urllib.parse import quote
10+ >>> from urllib.parse import quote
11 >>> from zope.interface import implementer
12 >>> from lazr.restful.security import protect_schema
13 >>> @implementer(IContact, ILocation)
14diff --git a/src/lazr/restful/docs/webservice-declarations.rst b/src/lazr/restful/docs/webservice-declarations.rst
15index 964f5ff..2a8eb46 100644
16--- a/src/lazr/restful/docs/webservice-declarations.rst
17+++ b/src/lazr/restful/docs/webservice-declarations.rst
18@@ -55,8 +55,8 @@ These declarations add tagged values to the original interface elements.
19 The tags are in the lazr.restful namespace and are dictionaries of
20 elements.
21
22+ >>> from collections.abc import Mapping
23 >>> from pprint import pformat
24- >>> from six.moves.collections_abc import Mapping
25 >>> def print_export_tag(element):
26 ... """Print the content of the 'lazr.restful.exported' tag."""
27 ... def format_value(value):
28@@ -1285,7 +1285,7 @@ URL to the newly created object. The body of the response will be empty.
29 (For the URL generation to work, we need to register an IAbsoluteURL
30 adapter and set the request as the current interaction.)
31
32- >>> from six.moves.urllib.parse import quote
33+ >>> from urllib.parse import quote
34 >>> from zope.component import provideAdapter
35 >>> from zope.traversing.browser.interfaces import IAbsoluteURL
36 >>> from zope.publisher.interfaces.http import IHTTPApplicationRequest
37diff --git a/src/lazr/restful/docs/webservice.rst b/src/lazr/restful/docs/webservice.rst
38index 6397038..5289633 100644
39--- a/src/lazr/restful/docs/webservice.rst
40+++ b/src/lazr/restful/docs/webservice.rst
41@@ -114,7 +114,7 @@ interface, and the URL of an object is found by using the IAbsoluteURL
42 interface.
43
44
45- >>> from six.moves.urllib.parse import quote
46+ >>> from urllib.parse import quote
47 >>> from zope.component import (
48 ... adapter, getSiteManager, getMultiAdapter)
49 >>> from zope.interface import implementer
50@@ -201,7 +201,7 @@ interface.
51
52 >>> protect_schema(Cookbook, ICookbook, write_permission=CheckerPublic)
53
54- >>> from six.moves.urllib.parse import unquote
55+ >>> from urllib.parse import unquote
56 >>> @implementer(IPublishTraverse)
57 ... @adapter(ICookbook, IBrowserRequest)
58 ... class CookbookTraversal:
59diff --git a/src/lazr/restful/example/base/tests/collection.txt b/src/lazr/restful/example/base/tests/collection.txt
60index 08009ad..c2a47dc 100644
61--- a/src/lazr/restful/example/base/tests/collection.txt
62+++ b/src/lazr/restful/example/base/tests/collection.txt
63@@ -85,7 +85,7 @@ results in a 400 error.
64
65 A collection may be empty.
66
67- >>> from six.moves.urllib.parse import quote
68+ >>> from urllib.parse import quote
69 >>> url = quote("/cookbooks/Cooking Without Recipes/recipes")
70 >>> result = webservice.get(url)
71 >>> list(result.jsonBody()['entries'])
72diff --git a/src/lazr/restful/example/base/tests/entry.txt b/src/lazr/restful/example/base/tests/entry.txt
73index ba48787..c260361 100644
74--- a/src/lazr/restful/example/base/tests/entry.txt
75+++ b/src/lazr/restful/example/base/tests/entry.txt
76@@ -22,7 +22,7 @@ GET request to the entry's URL.
77
78 Here we see that the cookbook 'Everyday Greens' is a vegetarian cookbook.
79
80- >>> from six.moves.urllib.parse import quote
81+ >>> from urllib.parse import quote
82 >>> greens_url = quote("/cookbooks/Everyday Greens")
83 >>> print(webservice.get(greens_url).jsonBody()['cuisine'])
84 Vegetarian
85diff --git a/src/lazr/restful/example/base/tests/field.txt b/src/lazr/restful/example/base/tests/field.txt
86index aa09231..a1e51c7 100644
87--- a/src/lazr/restful/example/base/tests/field.txt
88+++ b/src/lazr/restful/example/base/tests/field.txt
89@@ -8,7 +8,7 @@ field resource itself, rather than PUT/PATCH to the entry.
90 >>> from lazr.restful.testing.webservice import WebServiceCaller
91 >>> webservice = WebServiceCaller(domain='cookbooks.dev')
92
93- >>> from six.moves.urllib.parse import quote
94+ >>> from urllib.parse import quote
95 >>> cookbook_url = quote("/cookbooks/The Joy of Cooking")
96 >>> field_url = cookbook_url + "/description"
97
98diff --git a/src/lazr/restful/example/base/tests/hostedfile.txt b/src/lazr/restful/example/base/tests/hostedfile.txt
99index 4725646..53ff057 100644
100--- a/src/lazr/restful/example/base/tests/hostedfile.txt
101+++ b/src/lazr/restful/example/base/tests/hostedfile.txt
102@@ -15,7 +15,7 @@ File resources
103
104 A cookbook starts out with a link to a cover image, but no actual cover.
105
106- >>> from six.moves.urllib.parse import quote
107+ >>> from urllib.parse import quote
108 >>> greens_url = quote("/cookbooks/Everyday Greens")
109 >>> greens = webservice.get(greens_url).jsonBody()
110 >>> print(greens['cover_link'])
111diff --git a/src/lazr/restful/example/base/tests/representation-cache.txt b/src/lazr/restful/example/base/tests/representation-cache.txt
112index 7870eac..0b6a340 100644
113--- a/src/lazr/restful/example/base/tests/representation-cache.txt
114+++ b/src/lazr/restful/example/base/tests/representation-cache.txt
115@@ -211,7 +211,7 @@ POST did.
116 >>> print(list(dictionary.keys())[0])
117 http://.../devel/cookbooks/Everyday%20Greens,application/json
118
119- >>> from six.moves.urllib.parse import quote
120+ >>> from urllib.parse import quote
121 >>> greens_url = quote("/cookbooks/Everyday Greens")
122 >>> ignore = webservice.named_post(
123 ... greens_url, "replace_cover", cover="foo")
124diff --git a/src/lazr/restful/example/base/tests/service.txt b/src/lazr/restful/example/base/tests/service.txt
125index dcaf6cf..67e7ac3 100644
126--- a/src/lazr/restful/example/base/tests/service.txt
127+++ b/src/lazr/restful/example/base/tests/service.txt
128@@ -59,7 +59,7 @@ resource yields a 405 error.
129 Allow: GET POST
130 ...
131
132- >>> from six.moves.urllib.parse import quote
133+ >>> from urllib.parse import quote
134 >>> print(webservice.delete(quote("/dishes/Roast chicken")))
135 HTTP/1.1 405 Method Not Allowed...
136 Allow: GET PUT PATCH
137diff --git a/src/lazr/restful/example/base/tests/wadl.txt b/src/lazr/restful/example/base/tests/wadl.txt
138index e9ba3e9..47ea28f 100644
139--- a/src/lazr/restful/example/base/tests/wadl.txt
140+++ b/src/lazr/restful/example/base/tests/wadl.txt
141@@ -12,7 +12,7 @@ Entry resources
142 Let's get a WADL representation of an entry resource (in this case, a
143 cookbook), and see what's inside.
144
145- >>> from six.moves.urllib.parse import quote
146+ >>> from urllib.parse import quote
147 >>> from lazr.restful.testing.webservice import WebServiceCaller
148 >>> webservice = WebServiceCaller(domain='cookbooks.dev')
149 >>> entry_url = quote("/cookbooks/The Joy of Cooking")
150diff --git a/src/lazr/restful/example/base/traversal.py b/src/lazr/restful/example/base/traversal.py
151index 4ae07a9..a48f346 100644
152--- a/src/lazr/restful/example/base/traversal.py
153+++ b/src/lazr/restful/example/base/traversal.py
154@@ -9,11 +9,11 @@ __all__ = [
155 "TraverseWithGet",
156 ]
157
158-
159-from six.moves.urllib.parse import (
160+from urllib.parse import (
161 unquote,
162 urlparse,
163 )
164+
165 from zope.component import getUtility
166 from zope.publisher.interfaces import IPublishTraverse, NotFound
167 from zope.publisher.interfaces.browser import IDefaultBrowserLayer
168diff --git a/src/lazr/restful/marshallers.py b/src/lazr/restful/marshallers.py
169index 3439106..20f6f9e 100644
170--- a/src/lazr/restful/marshallers.py
171+++ b/src/lazr/restful/marshallers.py
172@@ -25,10 +25,10 @@ from collections import OrderedDict
173 from datetime import datetime
174 from io import BytesIO
175 import re
176+from urllib.parse import unquote
177
178 import pytz
179 import simplejson
180-from six.moves.urllib.parse import unquote
181
182 from zope.datetime import (
183 DateTimeError,
184diff --git a/src/lazr/restful/publisher.py b/src/lazr/restful/publisher.py
185index 92b668a..67e4ea0 100644
186--- a/src/lazr/restful/publisher.py
187+++ b/src/lazr/restful/publisher.py
188@@ -12,13 +12,13 @@ __all__ = [
189 "WebServiceRequestTraversal",
190 ]
191
192-
193-import simplejson
194-from six.moves.urllib.parse import (
195+from urllib.parse import (
196 quote,
197 urlsplit,
198 urlunsplit,
199 )
200+
201+import simplejson
202 from zope.component import (
203 adapter,
204 getMultiAdapter,
205diff --git a/src/lazr/restful/simple.py b/src/lazr/restful/simple.py
206index 2c58320..3a2b271 100644
207--- a/src/lazr/restful/simple.py
208+++ b/src/lazr/restful/simple.py
209@@ -16,11 +16,11 @@ __all__ = [
210 ]
211
212 import traceback
213-
214-from six.moves.urllib.parse import (
215+from urllib.parse import (
216 quote,
217 unquote,
218 )
219+
220 from zope.component import (
221 adapter,
222 getMultiAdapter,
223diff --git a/src/lazr/restful/tales.py b/src/lazr/restful/tales.py
224index 0be2185..6b975fe 100644
225--- a/src/lazr/restful/tales.py
226+++ b/src/lazr/restful/tales.py
227@@ -30,6 +30,7 @@ import operator
228 import re
229 import simplejson
230 import textwrap
231+from urllib.parse import quote
232
233 from docutils import io
234 from docutils.core import Publisher
235@@ -45,7 +46,6 @@ from docutils.writers.html4css1 import (
236 Writer as HTMLWriter,
237 )
238 from docutils.writers.null import Writer as NullWriter
239-from six.moves.urllib.parse import quote
240 from zope.component import (
241 adapter,
242 getGlobalSiteManager,
243diff --git a/src/lazr/restful/testing/webservice.py b/src/lazr/restful/testing/webservice.py
244index 148fd4c..85e8ba6 100644
245--- a/src/lazr/restful/testing/webservice.py
246+++ b/src/lazr/restful/testing/webservice.py
247@@ -27,14 +27,14 @@ import simplejson
248 import sys
249 from types import ModuleType
250 import unittest
251+from urllib.parse import (
252+ quote,
253+ urljoin,
254+)
255
256 import wsgi_intercept
257
258 import six
259-from six.moves.urllib.parse import (
260- quote,
261- urljoin,
262-)
263 from zope.component import adapter, getGlobalSiteManager, getUtility
264 from zope.configuration import xmlconfig
265 from zope.interface import alsoProvides, implementer, Interface

Subscribers

People subscribed via source and target branches