Merge ~cjwatson/layer-coordinator:config-flags into layer-coordinator:master

Proposed by Colin Watson
Status: Needs review
Proposed branch: ~cjwatson/layer-coordinator:config-flags
Merge into: layer-coordinator:master
Diff against target: 132 lines (+40/-24)
4 files modified
hooks/coordinator-relation-changed (+10/-6)
hooks/coordinator-relation-departed (+10/-6)
hooks/leader-elected (+10/-6)
hooks/leader-settings-changed (+10/-6)
Reviewer Review Type Date Requested Status
Stuart Bishop Pending
Review via email: mp+441314@code.launchpad.net

Commit message

Update hooks to handle setting config flags

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/hooks/coordinator-relation-changed b/hooks/coordinator-relation-changed
2index fe39f65..9858c6b 100755
3--- a/hooks/coordinator-relation-changed
4+++ b/hooks/coordinator-relation-changed
5@@ -1,18 +1,22 @@
6 #!/usr/bin/env python3
7
8-# Load modules from $CHARM_DIR/lib
9+# Load modules from $JUJU_CHARM_DIR/lib
10 import sys
11 sys.path.append('lib')
12
13-from charms.layer.basic import bootstrap_charm_deps
14-bootstrap_charm_deps()
15+from charms.layer import basic # noqa
16+basic.bootstrap_charm_deps()
17+
18+from charmhelpers.core import hookenv # noqa
19+hookenv.atstart(basic.init_config_states)
20+hookenv.atexit(basic.clear_config_states)
21
22
23 # This will load and run the appropriate @hook and other decorated
24-# handlers from $CHARM_DIR/reactive, $CHARM_DIR/hooks/reactive,
25-# and $CHARM_DIR/hooks/relations.
26+# handlers from $JUJU_CHARM_DIR/reactive, $JUJU_CHARM_DIR/hooks/reactive,
27+# and $JUJU_CHARM_DIR/hooks/relations.
28 #
29 # See https://jujucharms.com/docs/stable/authors-charm-building
30 # for more information on this pattern.
31-from charms.reactive import main
32+from charms.reactive import main # noqa
33 main()
34diff --git a/hooks/coordinator-relation-departed b/hooks/coordinator-relation-departed
35index fe39f65..9858c6b 100755
36--- a/hooks/coordinator-relation-departed
37+++ b/hooks/coordinator-relation-departed
38@@ -1,18 +1,22 @@
39 #!/usr/bin/env python3
40
41-# Load modules from $CHARM_DIR/lib
42+# Load modules from $JUJU_CHARM_DIR/lib
43 import sys
44 sys.path.append('lib')
45
46-from charms.layer.basic import bootstrap_charm_deps
47-bootstrap_charm_deps()
48+from charms.layer import basic # noqa
49+basic.bootstrap_charm_deps()
50+
51+from charmhelpers.core import hookenv # noqa
52+hookenv.atstart(basic.init_config_states)
53+hookenv.atexit(basic.clear_config_states)
54
55
56 # This will load and run the appropriate @hook and other decorated
57-# handlers from $CHARM_DIR/reactive, $CHARM_DIR/hooks/reactive,
58-# and $CHARM_DIR/hooks/relations.
59+# handlers from $JUJU_CHARM_DIR/reactive, $JUJU_CHARM_DIR/hooks/reactive,
60+# and $JUJU_CHARM_DIR/hooks/relations.
61 #
62 # See https://jujucharms.com/docs/stable/authors-charm-building
63 # for more information on this pattern.
64-from charms.reactive import main
65+from charms.reactive import main # noqa
66 main()
67diff --git a/hooks/leader-elected b/hooks/leader-elected
68index fe39f65..9858c6b 100755
69--- a/hooks/leader-elected
70+++ b/hooks/leader-elected
71@@ -1,18 +1,22 @@
72 #!/usr/bin/env python3
73
74-# Load modules from $CHARM_DIR/lib
75+# Load modules from $JUJU_CHARM_DIR/lib
76 import sys
77 sys.path.append('lib')
78
79-from charms.layer.basic import bootstrap_charm_deps
80-bootstrap_charm_deps()
81+from charms.layer import basic # noqa
82+basic.bootstrap_charm_deps()
83+
84+from charmhelpers.core import hookenv # noqa
85+hookenv.atstart(basic.init_config_states)
86+hookenv.atexit(basic.clear_config_states)
87
88
89 # This will load and run the appropriate @hook and other decorated
90-# handlers from $CHARM_DIR/reactive, $CHARM_DIR/hooks/reactive,
91-# and $CHARM_DIR/hooks/relations.
92+# handlers from $JUJU_CHARM_DIR/reactive, $JUJU_CHARM_DIR/hooks/reactive,
93+# and $JUJU_CHARM_DIR/hooks/relations.
94 #
95 # See https://jujucharms.com/docs/stable/authors-charm-building
96 # for more information on this pattern.
97-from charms.reactive import main
98+from charms.reactive import main # noqa
99 main()
100diff --git a/hooks/leader-settings-changed b/hooks/leader-settings-changed
101index fe39f65..9858c6b 100755
102--- a/hooks/leader-settings-changed
103+++ b/hooks/leader-settings-changed
104@@ -1,18 +1,22 @@
105 #!/usr/bin/env python3
106
107-# Load modules from $CHARM_DIR/lib
108+# Load modules from $JUJU_CHARM_DIR/lib
109 import sys
110 sys.path.append('lib')
111
112-from charms.layer.basic import bootstrap_charm_deps
113-bootstrap_charm_deps()
114+from charms.layer import basic # noqa
115+basic.bootstrap_charm_deps()
116+
117+from charmhelpers.core import hookenv # noqa
118+hookenv.atstart(basic.init_config_states)
119+hookenv.atexit(basic.clear_config_states)
120
121
122 # This will load and run the appropriate @hook and other decorated
123-# handlers from $CHARM_DIR/reactive, $CHARM_DIR/hooks/reactive,
124-# and $CHARM_DIR/hooks/relations.
125+# handlers from $JUJU_CHARM_DIR/reactive, $JUJU_CHARM_DIR/hooks/reactive,
126+# and $JUJU_CHARM_DIR/hooks/relations.
127 #
128 # See https://jujucharms.com/docs/stable/authors-charm-building
129 # for more information on this pattern.
130-from charms.reactive import main
131+from charms.reactive import main # noqa
132 main()

Subscribers

People subscribed via source and target branches

to all changes: