Merge ~cjwatson/launchpadlib:fakelaunchpad-methods-returning-None into launchpadlib:main
Proposed by
Colin Watson
Status: | Merged |
---|---|
Merged at revision: | abef23b17f0fdd6b2091bc7c6784b24072d326c0 |
Proposed branch: | ~cjwatson/launchpadlib:fakelaunchpad-methods-returning-None |
Merge into: | launchpadlib:main |
Diff against target: |
58 lines (+12/-2) 4 files modified
NEWS.rst (+2/-0) src/launchpadlib/testing/launchpad.py (+1/-1) src/launchpadlib/testing/tests/test_launchpad.py (+8/-0) tox.ini (+1/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jürgen Gmach | Approve | ||
Review via email: mp+435156@code.launchpad.net |
Commit message
Support fake methods that return None
Description of the change
`FakeLaunchpad` is useful for writing test suites for packages that use `launchpadlib`. When trying to do so, I noticed a problem: attempting to register a fake method that returns None caused a crash. Real Launchpad webservice methods may return None, so fix this.
I also ran into a couple of issues with this package's `pytest` setup, and fixed those in passing.
To post a comment you must log in.