Merge lp:~cjwatson/launchpad/webhook-default-event-types into lp:launchpad
Proposed by
Colin Watson
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 17790 | ||||
Proposed branch: | lp:~cjwatson/launchpad/webhook-default-event-types | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
260 lines (+97/-12) 7 files modified
lib/lp/code/model/branch.py (+4/-0) lib/lp/code/model/gitrepository.py (+4/-0) lib/lp/services/webhooks/browser.py (+4/-1) lib/lp/services/webhooks/configure.zcml (+16/-7) lib/lp/services/webhooks/interfaces.py (+34/-4) lib/lp/services/webhooks/model.py (+9/-0) lib/lp/services/webhooks/tests/test_browser.py (+26/-0) |
||||
To merge this branch: | bzr merge lp:~cjwatson/launchpad/webhook-default-event-types | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | code | Approve | |
Review via email: mp+273054@code.launchpad.net |
Commit message
Only offer webhook event types that are valid for the target, and set reasonable defaults.
Description of the change
Only offer webhook event types that are valid for the target, and set reasonable defaults (currently just all the valid event types, but in future it may be a subset in some cases).
To post a comment you must log in.
Events are currently webhook-specific, and those properties aren't exported, so I'd say valid_webhook_ event_types and default_ webhook_ event_types.