Merge lp:~cjwatson/launchpad/upgrade-requests into lp:launchpad

Proposed by Colin Watson on 2015-02-27
Status: Merged
Merged at revision: 17578
Proposed branch: lp:~cjwatson/launchpad/upgrade-requests
Merge into: lp:launchpad
Diff against target: 12 lines (+1/-1)
1 file modified
versions.cfg (+1/-1)
To merge this branch: bzr merge lp:~cjwatson/launchpad/upgrade-requests
Reviewer Review Type Date Requested Status
William Grant code 2015-02-27 Approve on 2015-06-24
Review via email: mp+251337@code.launchpad.net

Commit Message

Upgrade to requests 2.5.1.

Description of the Change

Upgrade to requests 2.5.1. (Stuart added this to lp-source-dependencies a while back, but apparently didn't get round to upgrading Launchpad.)

I'd like to be able to use requests.post(json=) for my forthcoming Git hosting client, and that feature was added in requests 2.4.2.

To post a comment you must log in.
William Grant (wgrant) wrote :

I'm not completely comfortable with this right now, as we don't have a totally rock solid Swift setup on staging. We should get that looking closer to production just in case we're going to break our swiftclient usage/patches.

Colin Watson (cjwatson) wrote :

OK, fair enough. That's a bit beyond me for now, but I've switched back to old-school .post(headers={"Content-Type": "application/json"}, data=json.dumps(...)) for now to unblock myself on this.

William Grant (wgrant) wrote :

We now know enough about the occasional Swift issues on production that I'm comfortable upgrading this.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'versions.cfg'
2--- versions.cfg 2015-04-27 16:06:00 +0000
3+++ versions.cfg 2015-06-24 07:46:46 +0000
4@@ -107,7 +107,7 @@
5 python-swiftclient = 1.5.0
6 PyYAML = 3.10
7 rabbitfixture = 0.3.6
8-requests = 1.2.3
9+requests = 2.5.1
10 s4 = 0.1.2
11 setproctitle = 1.1.7
12 setuptools-git = 1.0