Merge lp:~cjwatson/launchpad/unverified-salesforce-proxy into lp:launchpad
Proposed by
Colin Watson
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 18367 | ||||
Proposed branch: | lp:~cjwatson/launchpad/unverified-salesforce-proxy | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
59 lines (+15/-6) 2 files modified
lib/lp/services/salesforce/proxy.py (+12/-3) lib/lp/services/timeout.py (+3/-3) |
||||
To merge this branch: | bzr merge lp:~cjwatson/launchpad/unverified-salesforce-proxy | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | code | Approve | |
Review via email: mp+323661@code.launchpad.net |
Commit message
Disable TLS certificate verification for the Salesforce proxy.
Description of the change
The proxy is currently running off a self-signed certificate, so xenial's Python dislikes it by default. We should probably sort out the certificate situation at some point, but there are better things to do than to try to tidy up canonical-sfi.
Automatic testing is awkward, but I've tested this manually by SSH-forwarding to niobium.
To post a comment you must log in.