Merge lp:~cjwatson/launchpad/uefi-signing-failures into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Curtis Hovey |
Approved revision: | no longer in the source branch. |
Merged at revision: | 16251 |
Proposed branch: | lp:~cjwatson/launchpad/uefi-signing-failures |
Merge into: | lp:launchpad |
Diff against target: |
299 lines (+59/-62) 7 files modified
lib/lp/archivepublisher/customupload.py (+2/-1) lib/lp/archivepublisher/ddtp_tarball.py (+2/-2) lib/lp/archivepublisher/debian_installer.py (+2/-2) lib/lp/archivepublisher/dist_upgrader.py (+2/-2) lib/lp/archivepublisher/tests/test_uefi.py (+15/-12) lib/lp/archivepublisher/uefi.py (+30/-37) lib/lp/soyuz/model/queue.py (+6/-6) |
To merge this branch: | bzr merge lp:~cjwatson/launchpad/uefi-signing-failures |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Curtis Hovey (community) | code | Approve | |
Review via email: mp+133666@code.launchpad.net |
Commit message
Make some UEFI-related errors into logged warnings instead, since they aren't important enough to justify the resulting publisher chaos.
Description of the change
== Summary ==
Bug 1071562: Failures when publishing UEFI custom uploads cause continuous republication attempts, resulting in vast numbers of excess BPPH rows.
== Proposed fix ==
The fundamental problem is that errors when publishing custom uploads involve non-transactional filesystem changes which are difficult to roll back; until that's fixed (perhaps by moving custom upload publication from process-accepted to the publisher proper), this is never going to be very graceful. However, we can at least avoid causing gratuitous trouble for ourselves by making some less important errors into logged warnings.
If nothing else, it is relatively common for people to copy kernel source from quantal to their PPA without removing the UEFI tarball emission or arranging for their PPA to have UEFI signing keys. This should be handled more gracefully by just not signing the resulting files.
== Tests ==
bin/test -vvct lp.archivepubli
== Demo and Q/A ==
Copy a version of efilinux that emits a UEFI tarball to a PPA without signing configuration, and make sure it gets published correctly.
Thank you.