Merge lp:~cjwatson/launchpad/ttb-pass-series into lp:launchpad

Proposed by Colin Watson
Status: Merged
Merged at revision: 18498
Proposed branch: lp:~cjwatson/launchpad/ttb-pass-series
Merge into: lp:launchpad
Diff against target: 43 lines (+10/-5)
2 files modified
lib/lp/translations/model/translationtemplatesbuildbehaviour.py (+3/-1)
lib/lp/translations/tests/test_translationtemplatesbuildbehaviour.py (+7/-4)
To merge this branch: bzr merge lp:~cjwatson/launchpad/ttb-pass-series
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+333380@code.launchpad.net

Commit message

Pass a "series" argument to translation templates builds; missed in r18441.

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :

Self-approving this as it's obvious and somewhat urgent (TTBs are entirely broken right now, and I can't QA the current round of launchpad-buildd fixes without fixing that).

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/translations/model/translationtemplatesbuildbehaviour.py'
2--- lib/lp/translations/model/translationtemplatesbuildbehaviour.py 2017-04-19 11:01:16 +0000
3+++ lib/lp/translations/model/translationtemplatesbuildbehaviour.py 2017-11-08 11:18:38 +0000
4@@ -53,9 +53,11 @@
5 return "translationtemplates_%s_%d.txt" % (safe_name, self.build.id)
6
7 def composeBuildRequest(self, logger):
8+ das = self._getDistroArchSeries()
9 args = {
10- 'arch_tag': self._getDistroArchSeries().architecturetag,
11+ 'arch_tag': das.architecturetag,
12 'branch_url': self.build.branch.composePublicURL(),
13+ 'series': das.distroseries.name,
14 }
15 return ("translation-templates", self._getDistroArchSeries(), {}, args)
16
17
18=== modified file 'lib/lp/translations/tests/test_translationtemplatesbuildbehaviour.py'
19--- lib/lp/translations/tests/test_translationtemplatesbuildbehaviour.py 2016-02-15 01:06:56 +0000
20+++ lib/lp/translations/tests/test_translationtemplatesbuildbehaviour.py 2017-11-08 11:18:38 +0000
21@@ -1,4 +1,4 @@
22-# Copyright 2010-2014 Canonical Ltd. This software is licensed under the
23+# Copyright 2010-2017 Canonical Ltd. This software is licensed under the
24 # GNU Affero General Public License version 3 (see the file LICENSE).
25
26 """Unit tests for TranslationTemplatesBuildBehaviour."""
27@@ -101,10 +101,13 @@
28 behaviour = self.makeBehaviour()
29 switch_dbuser(config.builddmaster.dbuser)
30 build_request = yield behaviour.composeBuildRequest(None)
31+ das = behaviour._getDistroArchSeries()
32 self.assertEqual(
33- ('translation-templates', behaviour._getDistroArchSeries(), {},
34- {'arch_tag': behaviour._getDistroArchSeries().architecturetag,
35- 'branch_url': behaviour.build.branch.composePublicURL()}),
36+ ('translation-templates', das, {}, {
37+ 'arch_tag': das.architecturetag,
38+ 'branch_url': behaviour.build.branch.composePublicURL(),
39+ 'series': das.distroseries.name,
40+ }),
41 build_request)
42
43 def test_getDistroArchSeries(self):