Launchpad itself

Merge lp:~cjwatson/launchpad/testfix-getallpermissions into lp:launchpad

  1. testfix-getallpermissions
  2. Merge into devel
Proposed by Colin Watson on 2012-08-17
Status: Merged
Approved by: William Grant on 2012-08-17
Approved revision: no longer in the source branch.
Merged at revision: 15824
Proposed branch: lp:~cjwatson/launchpad/testfix-getallpermissions
Merge into: lp:launchpad
Diff against target: 0 lines
To merge this branch: bzr merge lp:~cjwatson/launchpad/testfix-getallpermissions
Reviewer Review Type Date Requested Status
William Grant code 2012-08-17 Approve on 2012-08-17
Review via email: mp+120094@code.launchpad.net

Commit Message

Convert TestArchiveWebservice.test_getAllPermissions to the record_two_runs helper, which handles flushing database caches between runs.

Description of the Change

lp.soyuz.browser.tests.test_archive_webservice.TestArchiveWebservice.test_getAllPermissions failed in buildbot. This branch fixes that by converting it to the record_two_runs helper, thereby arranging to flush database caches between runs.

I had to change record_two_runs slightly to handle the case where item_creator leaves the test system logged out, because tests based on launchpadlib_for get upset if there's an interaction in place when entering launchpadlib. I've run all the other tests that use record_two_runs and they still pass.

To post a comment you must log in.
William Grant (wgrant) :
review: Approve (code)

Preview Diff

Empty