Merge lp:~cjwatson/launchpad/stop-publishing-obsolete-series into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Raphaël Badin |
Approved revision: | no longer in the source branch. |
Merged at revision: | 14622 |
Proposed branch: | lp:~cjwatson/launchpad/stop-publishing-obsolete-series |
Merge into: | lp:launchpad |
Diff against target: |
98 lines (+63/-1) 2 files modified
lib/lp/archivepublisher/publishing.py (+23/-1) lib/lp/archivepublisher/tests/test_publisher.py (+40/-0) |
To merge this branch: | bzr merge lp:~cjwatson/launchpad/stop-publishing-obsolete-series |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Raphaël Badin (community) | Approve | ||
Review via email: mp+86967@code.launchpad.net |
Commit message
[r=rvb][bug=905281] Skip publishing OBSOLETE and FUTURE series in PRIMARY and PARTNER archives.
Description of the change
== Summary ==
About 15 seconds of the primary archive publisher's runtime is spent considering obsolete distroseries. It's not a huge amount, but it would be nice to shave this off.
== Proposed fix ==
Exclude OBSOLETE and FUTURE series when publishing PRIMARY and PARTNER archives. The archive purpose restriction is because apparently OEM still has PPAs for obsolete series, as noted by William Grant pre-implementation.
== Tests ==
bin/test -vvct archivepublishe
== Demo and Q/A ==
Run the publisher on mawson. Given the current state of the dogfood database, the publisher log under "Step A: Publishing packages" should show it considering rusty, precise, oneiric, natty, maverick, lucid, newdog, hardy, testagain, and dozing, but not q-series, karmic, jaunty, intrepid, gutsy, feisty, edgy, dapper, breezy, hoary, or warty.
== lint ==
None.
This looks good to land. Maybe you could merge testPublishingS kipsObsoletePri marySeries and testPublishingS kipsFuturePrima rySeries into one single method to avoid code duplication.