Merge lp:~cjwatson/launchpad/sprd-utilities into lp:launchpad
Proposed by
Colin Watson
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 17887 | ||||
Proposed branch: | lp:~cjwatson/launchpad/sprd-utilities | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
302 lines (+78/-32) 6 files modified
lib/lp/code/browser/sourcepackagerecipe.py (+15/-14) lib/lp/code/configure.zcml (+10/-1) lib/lp/code/interfaces/sourcepackagerecipe.py (+25/-1) lib/lp/code/model/sourcepackagerecipe.py (+5/-3) lib/lp/code/model/sourcepackagerecipebuild.py (+9/-5) lib/lp/code/model/sourcepackagerecipedata.py (+14/-8) |
||||
To merge this branch: | bzr merge lp:~cjwatson/launchpad/sprd-utilities | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | code | Approve | |
Review via email: mp+282218@code.launchpad.net |
Commit message
Access recipe parsing via interfaces.
Description of the change
Access recipe parsing via interfaces.
This is a bit of refactoring before starting on Git recipe support; for that, we're going to want to push recipe text through a small amount of munging before passing it to RecipeParser, so it makes sense for it all to go through common code, and that ought to use an interface so that it can be used correctly from browser code.
To post a comment you must log in.
I don't understand why there are two interfaces and utilities, but otherwise good.