Merge lp:~cjwatson/launchpad/sourcefileurls-include-meta into lp:launchpad
Status: | Merged |
---|---|
Merged at revision: | 17861 |
Proposed branch: | lp:~cjwatson/launchpad/sourcefileurls-include-meta |
Merge into: | lp:launchpad |
Diff against target: |
436 lines (+210/-50) 5 files modified
lib/lp/soyuz/browser/tests/test_publishing_webservice.py (+100/-24) lib/lp/soyuz/interfaces/publishing.py (+7/-3) lib/lp/soyuz/model/publishing.py (+19/-6) lib/lp/soyuz/tests/test_publishing_models.py (+72/-14) lib/lp/testing/__init__.py (+12/-3) |
To merge this branch: | bzr merge lp:~cjwatson/launchpad/sourcefileurls-include-meta |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | code | Approve | |
Review via email: mp+276928@code.launchpad.net |
Commit message
Add include_meta option to SPPH.sourceFile
Description of the change
Add include_meta option to SPPH.sourceFile
This is mainly to support dgit, which needs to be able to fetch .dsc files from Launchpad and verify their contents without having to fetch a full Sources file (even if one were available for the .dsc in question) and its trust chain.
The include_meta option is rather weird, in that it causes the method in question to return a completely different type, and had I been doing this from scratch I would probably have added a new getSourceFiles method instead and deprecated sourceFileUrls over time. However, BPPH.binaryFile
While I was here, I also added sha256 to BPPH.binaryFile
I'd lean toward consistency wrt. SHA-1, but it doesn't really matter.