Merge lp:~cjwatson/launchpad/snap-pending-import into lp:launchpad
Proposed by
Colin Watson
Status: | Rejected |
---|---|
Rejected by: | Colin Watson |
Proposed branch: | lp:~cjwatson/launchpad/snap-pending-import |
Merge into: | lp:launchpad |
Diff against target: |
140 lines (+97/-0) 2 files modified
lib/lp/snappy/model/snapbuild.py (+25/-0) lib/lp/snappy/tests/test_snapbuild.py (+72/-0) |
To merge this branch: | bzr merge lp:~cjwatson/launchpad/snap-pending-import |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Launchpad code reviewers | Pending | ||
Review via email: mp+311391@code.launchpad.net |
Commit message
Don't dispatch SnapBuilds whose code object is empty, perhaps because an associated code import hasn't finished.
Description of the change
This should make it easier to create a code import, a snap, and some builds in quick succession (via automation) without needing to worry about whether the builds will be dispatched before the import has completed.
To post a comment you must log in.
Unmerged revisions
- 18280. By Colin Watson
-
Don't dispatch SnapBuilds whose code object is empty, perhaps because an associated code import hasn't finished.
This seems risky. The set of snap builds that have to be considered in each dispatch will grow without bound as imports fail or refs to non-commits attempt to be built. I suppose we could just have graphs of that and check them occasionally.