Merge lp:~cjwatson/launchpad/snap-max-retries into lp:launchpad
Proposed by
Colin Watson
| Status: | Merged |
|---|---|
| Merged at revision: | 18781 |
| Proposed branch: | lp:~cjwatson/launchpad/snap-max-retries |
| Merge into: | lp:launchpad |
| Diff against target: |
11 lines (+1/-1) 1 file modified
lib/lp/snappy/model/snapbuildjob.py (+1/-1) |
| To merge this branch: | bzr merge lp:~cjwatson/launchpad/snap-max-retries |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Daniel Manrique (community) | Approve | ||
| Launchpad code reviewers | Pending | ||
|
Review via email:
|
|||
Commit message
Bump SnapStoreUpload
Description of the change
The store's timeout is currently 18 minutes.
This should probably be a configuration item at some point, but this will do for now.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM. The store's timeout is tunable so we can make that lower easily but for now 18 minutes seems to be what we need. Setting this value to 30 should result in about 27:30 minutes of retries from Launchpad (up from the previous 17:30 which was uncomfortably close to the 18-minute store timeout).