Merge lp:~cjwatson/launchpad/snap-channels-ui into lp:launchpad
Proposed by
Colin Watson
Status: | Merged |
---|---|
Merged at revision: | 18144 |
Proposed branch: | lp:~cjwatson/launchpad/snap-channels-ui |
Merge into: | lp:launchpad |
Prerequisite: | lp:~cjwatson/launchpad/snap-channels-job |
Diff against target: |
351 lines (+122/-8) 10 files modified
lib/lp/scripts/utilities/importfascist.py (+3/-1) lib/lp/snappy/browser/snap.py (+15/-3) lib/lp/snappy/browser/snapbuild.py (+5/-0) lib/lp/snappy/browser/tests/test_snap.py (+33/-3) lib/lp/snappy/browser/tests/test_snapbuild.py (+19/-0) lib/lp/snappy/templates/snap-edit.pt (+4/-0) lib/lp/snappy/templates/snap-index.pt (+10/-0) lib/lp/snappy/templates/snap-new.pt (+4/-0) lib/lp/snappy/vocabularies.py (+18/-1) lib/lp/snappy/vocabularies.zcml (+11/-0) |
To merge this branch: | bzr merge lp:~cjwatson/launchpad/snap-channels-ui |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Thomi Richards (community) | Approve | ||
Launchpad code reviewers | Pending | ||
Review via email: mp+298811@code.launchpad.net |
Commit message
Add UI for automatically releasing snap packages.
Description of the change
Add UI for automatically releasing snap packages.
This will require firewall changes first to let the appservers talk to search.
To post a comment you must log in.
Hi Colin,
The code looks fine, but when running './bin/test -cvvt snap' I get this message printed out while running many of the tests:
Traceback (most recent call last): thomi/launchpad /lp-branches/ snap-channels- ui/lib/ lp/snappy/ tests/test_ snap.py" , line 422, in test_getBuildSu mmariesForSnapB uildIds_ log_size_ field makeSnap( ) thomi/launchpad /lp-branches/ snap-channels- ui/lib/ lp/testing/ factory. py", line 390, in with_default_ master_ store thomi/launchpad /lp-branches/ snap-channels- ui/lib/ lp/testing/ factory. py", line 4664, in makeSnap channels= store_channels) thomi/launchpad /lp-branches/ snap-channels- ui/lib/ lp/snappy/ model/snap. py", line 531, in new thomi/launchpad /lp-branches/ snap-channels- ui/lib/ lp/snappy/ model/snap. py", line 583, in exists (owner, name) is not None thomi/launchpad /lp-branches/ snap-channels- ui/lib/ lp/snappy/ model/snap. py", line 579, in _getByName thomi/launchpad /lp-sourcedeps/ eggs/storm- 0.19.0. 99_lpwithnodate time_r408- py2.7-linux- i686.egg/ storm/store. py", line 1162, in one _connection. execute( select) thomi/launchpad /lp-sourcedeps/ eggs/storm- 0.19.0. 99_lpwithnodate time_r408- py2.7-linux- i686.egg/ storm/databases /postgres. py", line 266, in execute execute( self, statement, params, noresult) thomi/launchpad /lp-sourcedeps/ eggs/storm- 0.19.0. 99_lpwithnodate time_r408- py2.7-linux- i686.egg/ storm/database. py", line 238, in execute execute( statement, params) thomi/launchpad /lp-sourcedeps/ eggs/storm- 0.19.0. 99_lpwithnodate time_r408- py2.7-linux- i686.egg/ storm/databases /postgres. py", line 276, in raw_execute raw_execute( self, statement, params) thomi/launchpad /lp-sourcedeps/ eggs/storm- 0.19.0. 99_lpwithnodate time_r408- py2.7-linux- i686.egg/ storm/database. py", line 322, in raw_execute _check_ disconnect( raw_cursor. execute, *args) thomi/launchpad /lp-sourcedeps/ eggs/storm- 0.19.0. 99_lpwithnodate time_r408- py2.7-linux- i686.egg/ storm/database. py", line 371, in _check_disconnect thomi/launchpad /lp-branches/ snap-channels- ui/lib/ lp/testing/ pgsql.py" , line 118, in execute cursor. execute( *args, **kwargs) build_archive, Snap.auto_b...
File "/home/
snap = self.factory.
File "/home/
return func(*args, **kw)
File "/home/
store_
File "/home/
if self.exists(owner, name):
File "/home/
return self._getByName
File "/home/
Snap, Snap.owner == owner, Snap.name == name).one()
File "/home/
result = self._store.
File "/home/
return Connection.
File "/home/
raw_cursor = self.raw_
File "/home/
return Connection.
File "/home/
self.
File "/home/
return function(*args, **kwargs)
File "/home/
return self.real_
ProgrammingError: column snap.auto_build does not exist
LINE 1: SELECT Snap.auto_build, Snap.auto_
I'm not convinced this has anything to do with your branch.... any ideas? I've run the clean, build and schema targets. Not sure what else could be causing this?
I'll leave a provisional +1 here in any case.